Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1711)

Unified Diff: content/public/browser/download_manager.h

Issue 10915180: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_manager.h
diff --git a/content/public/browser/download_manager.h b/content/public/browser/download_manager.h
index b96fcbcf44f396c07607b4674991567f5cec50ff..e6e5e73fecb817065f817d64304dbef1c37e0f68 100644
--- a/content/public/browser/download_manager.h
+++ b/content/public/browser/download_manager.h
@@ -87,6 +87,7 @@ class CONTENT_EXPORT DownloadManager
// OnDownloadCreated(). TODO(<whoever>): When we've fully specified the
// possible states of the DownloadItem in download_item.h and removed
// ModelChanged, we should remove the caveat above.
+ // DO NOT create another download synchronously in OnDownloadCreated().
virtual void OnDownloadCreated(
DownloadManager* manager, DownloadItem* item) {}
@@ -172,13 +173,16 @@ class CONTENT_EXPORT DownloadManager
// Called by the embedder, after creating the download manager, to let it know
// about downloads from previous runs of the browser.
- virtual void OnPersistentStoreQueryComplete(
- std::vector<DownloadPersistentStoreInfo>* entries) = 0;
-
- // Called by the embedder, in response to
- // DownloadManagerDelegate::AddItemToPersistentStore.
- virtual void OnItemAddedToPersistentStore(int32 download_id,
- int64 db_handle) = 0;
+ virtual DownloadItem* CreateDownloadItem(
+ const FilePath& path,
+ const GURL& url,
+ const GURL& referrer_url,
+ const base::Time& start_time,
+ const base::Time& end_time,
+ int64 received_bytes,
+ int64 total_bytes,
+ DownloadItem::DownloadState state,
+ bool opened) = 0;
// The number of in progress (including paused) downloads.
virtual int InProgressCount() const = 0;
@@ -198,9 +202,6 @@ class CONTENT_EXPORT DownloadManager
// it is or state it's in.
virtual DownloadItem* GetDownload(int id) = 0;
- // Called when Save Page download is done.
- virtual void SavePageDownloadFinished(DownloadItem* download) = 0;
-
// Get the download item from the active map. Useful when the item is not
// yet in the history map.
virtual DownloadItem* GetActiveDownloadItem(int id) = 0;

Powered by Google App Engine
This is Rietveld 408576698