Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: chrome/browser/history/history_backend.cc

Issue 10915180: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend.cc
diff --git a/chrome/browser/history/history_backend.cc b/chrome/browser/history/history_backend.cc
index 9f7b0d6adbdf16411191d41aca012d3b6e55acc6..87dbdc3fc80cfb614c87c63cbb19cc60225ad5f2 100644
--- a/chrome/browser/history/history_backend.cc
+++ b/chrome/browser/history/history_backend.cc
@@ -23,6 +23,7 @@
#include "chrome/browser/api/bookmarks/bookmark_service.h"
#include "chrome/browser/autocomplete/history_url_provider.h"
#include "chrome/browser/common/cancelable_request.h"
+#include "chrome/browser/history/download_persistent_store_info.h"
#include "chrome/browser/history/history_notifications.h"
#include "chrome/browser/history/history_publisher.h"
#include "chrome/browser/history/in_memory_history_backend.h"
@@ -33,7 +34,6 @@
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/url_constants.h"
-#include "content/public/browser/download_persistent_store_info.h"
#include "googleurl/src/gurl.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
@@ -1220,40 +1220,26 @@ void HistoryBackend::CleanUpInProgressEntries() {
// Update a particular download entry.
void HistoryBackend::UpdateDownload(
- const content::DownloadPersistentStoreInfo& data) {
+ const DownloadPersistentStoreInfo& data) {
if (db_.get())
db_->UpdateDownload(data);
}
-// Update the path of a particular download entry.
-void HistoryBackend::UpdateDownloadPath(const FilePath& path,
- int64 db_handle) {
- if (db_.get())
- db_->UpdateDownloadPath(path, db_handle);
-}
-
// Create a new download entry and pass back the db_handle to it.
void HistoryBackend::CreateDownload(
scoped_refptr<DownloadCreateRequest> request,
- int32 id,
- const content::DownloadPersistentStoreInfo& history_info) {
+ const DownloadPersistentStoreInfo& history_info) {
int64 db_handle = 0;
if (!request->canceled()) {
if (db_.get())
db_handle = db_->CreateDownload(history_info);
- request->ForwardResult(id, db_handle);
+ request->ForwardResult(db_handle);
}
}
-void HistoryBackend::RemoveDownload(int64 db_handle) {
- if (db_.get())
- db_->RemoveDownload(db_handle);
-}
-
-void HistoryBackend::RemoveDownloadsBetween(const Time remove_begin,
- const Time remove_end) {
+void HistoryBackend::RemoveDownloads(const std::set<int64>& db_handles) {
if (db_.get())
- db_->RemoveDownloadsBetween(remove_begin, remove_end);
+ db_->RemoveDownloads(db_handles);
}
void HistoryBackend::QueryHistory(scoped_refptr<QueryHistoryRequest> request,

Powered by Google App Engine
This is Rietveld 408576698