Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

Issue 10915180: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: @r166680 Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/chrome_download_manager_delegate_unittest.cc
diff --git a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
index db9de71f5d44e3c555136c26f6fdc4555c56b1cb..23aac174f9b01542c33c15320be7c1e6eeb75c58 100644
--- a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
@@ -303,6 +303,10 @@ void ChromeDownloadManagerDelegateTest::SetUp() {
CHECK(profile());
delegate_ = new TestChromeDownloadManagerDelegate(profile());
+ EXPECT_CALL(*download_manager_.get(), GetAllDownloads(_))
+ .WillRepeatedly(Return());
+ EXPECT_CALL(*download_manager_.get(), AddObserver(_))
+ .WillRepeatedly(Return());
delegate_->SetDownloadManager(download_manager_.get());
pref_service_ = profile()->GetTestingPrefService();
web_contents()->SetDelegate(&web_contents_delegate_);
@@ -329,6 +333,12 @@ content::MockDownloadItem*
ChromeDownloadManagerDelegateTest::CreateActiveDownloadItem(int32 id) {
content::MockDownloadItem* item =
new ::testing::NiceMock<content::MockDownloadItem>();
+ EXPECT_CALL(*item, GetState())
+ .WillRepeatedly(Return(DownloadItem::IN_PROGRESS));
+ EXPECT_CALL(*item, AddObserver(_))
+ .WillRepeatedly(Return());
+ EXPECT_CALL(*item, RemoveObserver(_))
+ .WillRepeatedly(Return());
ON_CALL(*item, GetFullPath())
.WillByDefault(ReturnRefOfCopy(FilePath()));
ON_CALL(*item, GetHash())

Powered by Google App Engine
This is Rietveld 408576698