Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 10915180: Make DownloadHistory observe manager, items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: @r165669 Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 963ac9613b431226fb22af64b1e392af5abab6d1..a98f81da8e50747ba53a5acd507690455bd4de80 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -863,9 +863,6 @@ bool DownloadsGetFileIconFunction::RunImpl() {
if (!download_item && incognito_manager)
download_item = incognito_manager->GetDownload(params->download_id);
if (!download_item || download_item->GetTargetFilePath().empty()) {
- // The DownloadItem is is added to history when the path is determined. If
- // the download is not in history, then we don't have a path / final
- // filename and no icon.
error_ = download_extension_errors::kInvalidOperationError;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698