Make DownloadHistory observe manager, items

content/public/test/download_test_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/download_test_observer.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 88 matching lines @@
 
 DownloadTestObserver::~DownloadTestObserver() {
   for (DownloadSet::iterator it = downloads_observed_.begin();
        it != downloads_observed_.end(); ++it)
     (*it)->RemoveObserver(this);
 
   download_manager_->RemoveObserver(this);
 }
 
 void DownloadTestObserver::Init() {
-  download_manager_->AddObserver(this);  // Will call initial ModelChanged().
+  download_manager_->AddObserver(this);
+  std::vector<DownloadItem*> downloads;
+  download_manager_->GetAllDownloads(&downloads);
+  for (std::vector<DownloadItem*>::iterator it = downloads.begin();
+       it != downloads.end(); ++it) {
+    OnDownloadCreated(download_manager_, *it);
+  }
   finished_downloads_at_construction_ = finished_downloads_.size();
   states_observed_.clear();
 }
 
 void DownloadTestObserver::WaitForFinished() {
   if (!IsFinished()) {
     waiting_ = true;
     RunMessageLoop();
     waiting_ = false;
   }
@@ skipping 46 matching lines @@
 
       default:
         NOTREACHED();
     }
   }
 
   if (IsDownloadInFinalState(download))
     DownloadInFinalState(download);
 }
 
-void DownloadTestObserver::ModelChanged(DownloadManager* manager) {
+void DownloadTestObserver::OnDownloadCreated(
+    DownloadManager* manager, DownloadItem* item) {
   DCHECK_EQ(manager, download_manager_);
+  OnDownloadUpdated(item);
 
-  // Regenerate DownloadItem observers.  If there are any download items
-  // in our final state, note them in |finished_downloads_|
-  // (done by |OnDownloadUpdated()|).
-  std::vector<DownloadItem*> downloads;
-  download_manager_->GetAllDownloads(&downloads);
+  DownloadSet::const_iterator finished_it(finished_downloads_.find(item));
+  DownloadSet::iterator observed_it(downloads_observed_.find(item));
 
-  for (std::vector<DownloadItem*>::iterator it = downloads.begin();
-       it != downloads.end(); ++it) {
-    OnDownloadUpdated(*it);  // Safe to call multiple times; checks state.
+  // If it isn't finished and we're aren't observing it, start.
+  if (finished_it == finished_downloads_.end() &&
+      observed_it == downloads_observed_.end()) {
+    item->AddObserver(this);
+    downloads_observed_.insert(item);
+  }
 
-    DownloadSet::const_iterator finished_it(finished_downloads_.find(*it));
-    DownloadSet::iterator observed_it(downloads_observed_.find(*it));
-
-    // If it isn't finished and we're aren't observing it, start.
-    if (finished_it == finished_downloads_.end() &&
-        observed_it == downloads_observed_.end()) {
-      (*it)->AddObserver(this);
-      downloads_observed_.insert(*it);
-      continue;
-    }
-
-    // If it is finished and we are observing it, stop.
-    if (finished_it != finished_downloads_.end() &&
-        observed_it != downloads_observed_.end()) {
-      (*it)->RemoveObserver(this);
-      downloads_observed_.erase(observed_it);
-      continue;
-    }
+  // If it is finished and we are observing it, stop.
+  if (finished_it != finished_downloads_.end() &&
+      observed_it != downloads_observed_.end()) {
+    item->RemoveObserver(this);
+    downloads_observed_.erase(observed_it);
   }
 }
 
 size_t DownloadTestObserver::NumDangerousDownloadsSeen() const {
   return dangerous_downloads_seen_.size();
 }
 
 size_t DownloadTestObserver::NumDownloadsSeenInState(
     DownloadItem::DownloadState state) const {
   StateMap::const_iterator it = states_observed_.find(state);
@@ skipping 59 matching lines @@
   // instead.  In this case, it's because of |IsDownloadInFinalState()|.
   Init();
 }
 
 DownloadTestObserverInProgress::~DownloadTestObserverInProgress() {
 }
 
 
 bool DownloadTestObserverInProgress::IsDownloadInFinalState(
     DownloadItem* download) {
-  return (download->GetState() == DownloadItem::IN_PROGRESS);
+  return (download->GetState() == DownloadItem::IN_PROGRESS) &&
+    !download->GetTargetFilePath().empty();

[Randy Smith (Not in Mondays), 2012/09/24 18:03:25]

It's in test code, so I don't have strong feelings, but be aware that this may
cause unexpected flakiness because of change in behavior (the difference between
finishing before we execute the intermediate rename or after).

[benjhayden, 2012/09/24 20:12:11]

Could this CL (DownloadHistory-is-a-Observer) wait for another CL to rewrite all
these things to use DUO?

[Randy Smith (Not in Mondays), 2012/11/02 23:31:24]

I suppose, if you're volunteering.  But how would that help?  DUO still needs to
do some test on the DownloadItem, and it's the test that I'm calling out to you
as potentially being problematic.

[benjhayden, 2012/11/06 20:01:14]

Sorry, I don't know what I was thinking.
Yes, this is a slight change in behavior. I'll experiment to see if I still need
this.

 }
 
 DownloadTestFlushObserver::DownloadTestFlushObserver(
     DownloadManager* download_manager)
     : download_manager_(download_manager),
       waiting_for_zero_inprogress_(true) {}
 
 void DownloadTestFlushObserver::WaitForFlush() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   download_manager_->AddObserver(this);
@@ skipping 121 matching lines @@
     MessageLoopForUI::current()->Quit();
 }
 
 const DownloadUrlParameters::OnStartedCallback
     DownloadTestItemCreationObserver::callback() {
   return base::Bind(
       &DownloadTestItemCreationObserver::DownloadItemCreationCallback, this);
 }
 
 }  // namespace content