Make DownloadHistory observe manager, items

chrome/browser/download/download_status_updater_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "chrome/browser/download/download_status_updater.h"
 #include "content/public/test/mock_download_item.h"
 #include "content/public/test/mock_download_manager.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-using ::testing::AtLeast;
-using ::testing::Invoke;
-using ::testing::Mock;
-using ::testing::Return;
-using ::testing::SetArgPointee;
-using ::testing::StrictMock;
-using ::testing::WithArg;
-using ::testing::_;
+using testing::AtLeast;
+using testing::Invoke;
+using testing::Mock;
+using testing::Return;
+using testing::SetArgPointee;
+using testing::StrictMock;
+using testing::WithArg;
+using testing::_;

[Randy Smith (Not in Mondays), 2012/09/24 18:03:25]

Why in this CL?  I don't majorly object, just seems pretty random.

[benjhayden, 2012/09/24 20:12:11]

I was working with gmock in DownloadHistoryTest and noticed that these colons
aren't in [m]any other test files.
And they're ugly.

 
 class TestDownloadStatusUpdater : public DownloadStatusUpdater {
  public:
   TestDownloadStatusUpdater() : notification_count_(0),
                                 acceptable_notification_item_(NULL) {
   }
   void SetAcceptableNotificationItem(content::DownloadItem* item) {
     acceptable_notification_item_ = item;
   }
   size_t NotificationCount() {
@@ skipping 304 matching lines @@
   SetItemValues(0, 0, 10, 20, false);
   SetItemValues(0, 1, 50, 60, false);
   SetItemValues(1, 0, 80, 90, false);
 
   float progress = -1;
   int download_count = -1;
   EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
   EXPECT_FLOAT_EQ((10+50+80)/(20.0f+60+90), progress);
   EXPECT_EQ(3, download_count);
 }