Make DownloadHistory observe manager, items

content/public/browser/download_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active browser context in Chrome.
 //
 // Download observers:
@@ skipping 65 matching lines @@
   class CONTENT_EXPORT Observer {
    public:
     // A DownloadItem was created.  Unlike ModelChanged, this item may be
     // visible before the filename is determined; in this case the return value
     // of GetTargetFileName() will be null.  This method may be called an
     // arbitrary number of times, e.g. when loading history on startup.  As a
     // result, consumers should avoid doing large amounts of work in
     // OnDownloadCreated().  TODO(<whoever>): When we've fully specified the
     // possible states of the DownloadItem in download_item.h and removed
     // ModelChanged, we should remove the caveat above.
+    // DO NOT create another download synchronously in OnDownloadCreated().
     virtual void OnDownloadCreated(
         DownloadManager* manager, DownloadItem* item) {}
 
     // New or deleted download, observers should query us for the current set
     // of downloads.
     virtual void ModelChanged(DownloadManager* manager) {}
 
     // Called when the DownloadManager is being destroyed to prevent Observers
     // from calling back to a stale pointer.
     virtual void ManagerGoingDown(DownloadManager* manager) {}
@@ skipping 42 matching lines @@
   virtual void DownloadUrl(scoped_ptr<DownloadUrlParameters> parameters) = 0;
 
   // Allow objects to observe the download creation process.
   virtual void AddObserver(Observer* observer) = 0;
 
   // Remove a download observer from ourself.
   virtual void RemoveObserver(Observer* observer) = 0;
 
   // Called by the embedder, after creating the download manager, to let it know
   // about downloads from previous runs of the browser.
-  virtual void OnPersistentStoreQueryComplete(
-      std::vector<DownloadPersistentStoreInfo>* entries) = 0;
-
-  // Called by the embedder, in response to
-  // DownloadManagerDelegate::AddItemToPersistentStore.
-  virtual void OnItemAddedToPersistentStore(int32 download_id,
-                                            int64 db_handle) = 0;
+  virtual DownloadItem* CreateDownloadItem(
+      const FilePath& path,
+      const GURL& url,
+      const GURL& referrer_url,
+      const base::Time& start_time,
+      const base::Time& end_time,
+      int64 received_bytes,
+      int64 total_bytes,
+      DownloadItem::DownloadState state,
+      bool opened) = 0;
 
   // The number of in progress (including paused) downloads.
   virtual int InProgressCount() const = 0;
 
   virtual BrowserContext* GetBrowserContext() const = 0;
 
   // Checks whether downloaded files still exist. Updates state of downloads
   // that refer to removed files. The check runs in the background and may
   // finish asynchronously after this method returns.
   virtual void CheckForHistoryFilesRemoval() = 0;
 
   // Get the download item for |id| if present, no matter what type of download
   // it is or state it's in.
   virtual DownloadItem* GetDownload(int id) = 0;
 
-  // Called when Save Page download is done.
-  virtual void SavePageDownloadFinished(DownloadItem* download) = 0;
-
  protected:
   virtual ~DownloadManager() {}
 
  private:
   friend class base::RefCountedThreadSafe<DownloadManager>;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOWNLOAD_MANAGER_H_