Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 10915165: Don't depend on WEBKIT_IMPLEMENTATION guarded geometry conversion c'tors (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
nduca, enne (OOO)
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Don't depend on WEBKIT_IMPLEMENTATION guarded geometry conversion c'tors Since these files compile without WEBKIT_IMPLEMENTATION set the implicit WebRect -> WebCore::IntRect and related conversion c'tors aren't available. This defines a set of utility convert() functions and uses those to make the conversions explicit. When we switch CC geometry types we can delete these (if the cc API ends up using gfx:: types) or switch them to convert to the cc types. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155887

Patch Set 1 #

Patch Set 2 : add new files to gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -31 lines) Patch
M webkit/compositor_bindings/WebContentLayerImpl.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/WebExternalTextureLayerImpl.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/WebIOSurfaceLayerImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/compositor_bindings/WebLayerImpl.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M webkit/compositor_bindings/WebLayerTreeViewImpl.cpp View 6 chunks +10 lines, -9 lines 0 comments Download
M webkit/compositor_bindings/WebToCCInputHandlerAdapter.cpp View 4 chunks +7 lines, -4 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A webkit/compositor_bindings/webcore_convert.h View 1 chunk +31 lines, -0 lines 0 comments Download
A webkit/compositor_bindings/webcore_convert.cc View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jamesr
8 years, 3 months ago (2012-09-11 00:24:18 UTC) #1
nduca
8 years, 3 months ago (2012-09-11 00:26:14 UTC) #2
lgtm and holds my bikeshedding tongue

Powered by Google App Engine
This is Rietveld 408576698