Add Copy URL option to Omnibox context menu when URL is replaced by Instant Extended.

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h"
 
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"  // IDC_*
 #include "chrome/browser/ui/browser_list.h"
@@ skipping 78 matching lines @@
   DCHECK(observer);
   if (observer && observer->CanCopy())
     observer->CopyToPasteboard([NSPasteboard generalPasteboard]);
 }
 
 - (void)cut:(id)sender {
   [self copy:sender];
   [self delete:nil];
 }
 
+- (void)copyURL:(id)sender {
+  AutocompleteTextFieldObserver* observer = [self observer];
+  DCHECK(observer);
+  if (observer && observer->CanCopy())

[dhollowa, 2012/09/05 21:22:34]

nit: No need to handle DCHECK failure.  Prefer: if (observer->CanCopy())

[dominich, 2012/09/05 21:30:54]

Done.

+    observer->CopyURLToPasteboard([NSPasteboard generalPasteboard]);
+}
+
 // This class assumes that the delegate is an AutocompleteTextField.
 // Enforce that assumption.
 - (AutocompleteTextField*)delegate {
   AutocompleteTextField* delegate =
       static_cast<AutocompleteTextField*>([super delegate]);
   DCHECK(delegate == nil ||
          [delegate isKindOfClass:[AutocompleteTextField class]]);
   return delegate;
 }
 
@@ skipping 92 matching lines @@
   if (actionMenu)
     return actionMenu;
 
   NSMenu* menu = [[[NSMenu alloc] initWithTitle:@"TITLE"] autorelease];
   [menu addItemWithTitle:l10n_util::GetNSStringWithFixup(IDS_CUT)
                   action:@selector(cut:)
            keyEquivalent:@""];
   [menu addItemWithTitle:l10n_util::GetNSStringWithFixup(IDS_COPY)
                   action:@selector(copy:)
            keyEquivalent:@""];
+
+  if ([self isEditable]) {
+    // Copy URL if the URL has been replaced by the Extended Instant API.
+    AutocompleteTextFieldObserver* observer = [self observer];
+    DCHECK(observer);
+    if (observer && observer->ShouldAddCopyURL()) {

[dhollowa, 2012/09/05 21:22:34]

nit: No need to handle DCHECK failure.  Prefer: if
(observer->ShouldAddCopyURL())

[dominich, 2012/09/05 21:30:54]

Done.

+      NSString* label = l10n_util::GetNSStringWithFixup(IDS_COPY_URL_MAC);
+      [menu addItemWithTitle:label
+                      action:@selector(copyURL:)
+               keyEquivalent:@""];
+    }
+  }
+
   [menu addItemWithTitle:l10n_util::GetNSStringWithFixup(IDS_PASTE)
                   action:@selector(paste:)
            keyEquivalent:@""];
 
+

[dhollowa, 2012/09/05 21:22:34]

nit: remove extra line.

[dominich, 2012/09/05 21:30:54]

Done.

   // TODO(shess): If the control is not editable, should we show a
   // greyed-out "Paste and Go"?
   if ([self isEditable]) {
     // Paste and go/search.
     AutocompleteTextFieldObserver* observer = [self observer];
     DCHECK(observer);
     if (observer && observer->CanPasteAndGo()) {
       const int string_id = observer->GetPasteActionStringId();
       NSString* label = l10n_util::GetNSStringWithFixup(string_id);
 
@@ skipping 256 matching lines @@
   NSAttributedString* selection =
       [self attributedSubstringForProposedRange:selectedRange
                                     actualRange:NULL];
   if (!selection)
     return;
 
   [[FindPasteboard sharedInstance] setFindText:[selection string]];
 }
 
 @end