Add Copy URL option to Omnibox context menu when URL is replaced by Instant Extended.

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 190 matching lines @@
 // kAutocompleteEditFontPixelSizeInPopup. They should be changed accordingly
 // if font size for autocomplete edit (in popup) change.
 const int kAutocompleteVerticalMargin = 1;
 const int kAutocompleteVerticalMarginInPopup = 2;
 
 int GetEditFontPixelSize(bool popup_window_mode) {
   return popup_window_mode ? kAutocompleteEditFontPixelSizeInPopup :
                              kAutocompleteEditFontPixelSize;
 }
 
+void DoCopy(const string16& text, const BookmarkNodeData* bookmark_node_data) {
+  ui::Clipboard* cb = views::ViewsDelegate::views_delegate->GetClipboard();
+  ui::ScopedClipboardWriter scw(cb, ui::Clipboard::BUFFER_STANDARD);
+  scw.WriteText(text);
+  if (bookmark_node_data != NULL)
+    bookmark_node_data->WriteToClipboard(NULL);
+}
+
 }  // namespace
 
 // static
 const char OmniboxViewViews::kViewClassName[] = "BrowserOmniboxViewViews";
 
 OmniboxViewViews::OmniboxViewViews(OmniboxEditController* controller,
                                    ToolbarModel* toolbar_model,
                                    Profile* profile,
                                    CommandUpdater* command_updater,
                                    bool popup_window_mode,
@@ skipping 540 matching lines @@
   ui::Range selection_range;
   textfield_->GetSelectedRange(&selection_range);
   ui::Clipboard* cb = views::ViewsDelegate::views_delegate->GetClipboard();
   string16 selected_text;
   cb->ReadText(ui::Clipboard::BUFFER_STANDARD, &selected_text);
   const string16 text = textfield_->text();
   GURL url;
   bool write_url;
   model()->AdjustTextForCopy(selection_range.GetMin(), selected_text == text,
       &selected_text, &url, &write_url);
-  ui::ScopedClipboardWriter scw(cb, ui::Clipboard::BUFFER_STANDARD);
-  scw.WriteText(selected_text);
-  if (write_url) {
-    BookmarkNodeData data;
-    data.ReadFromTuple(url, text);
-    data.WriteToClipboard(NULL);
-  }
+  BookmarkNodeData data;
+  data.ReadFromTuple(url, text);

[Peter Kasting, 2012/09/11 21:52:59]

Nit: If DoCopy() takes 4 args (what used to be here as |selected_text|,
|write_url|, |url|, and |text|), you can move the BookmarkNodeData creation and
ReadFromTuple() call there and simplify both callsites.

[dominich, 2012/09/12 15:23:09]

Done.

+  DoCopy(selected_text, write_url ? &data : NULL);
 }
 
 void OmniboxViewViews::OnWriteDragData(ui::OSExchangeData* data) {
   ui::Range selection_range;
   textfield_->GetSelectedRange(&selection_range);
   string16 selected_text = textfield_->GetSelectedText();
   const string16 text = textfield_->text();
   GURL url;
   bool write_url;
   model()->AdjustTextForCopy(selection_range.start(), selected_text == text,
       &selected_text, &url, &write_url);
   data->SetString(selected_text);
   if (write_url)
     data->SetURL(url, selected_text);
 }
 
 void OmniboxViewViews::UpdateContextMenu(ui::SimpleMenuModel* menu_contents) {
   // Minor note: We use IDC_ for command id here while the underlying textfield
   // is using IDS_ for all its command ids. This is because views cannot depend
   // on IDC_ for now.
   menu_contents->AddItemWithStringId(IDC_EDIT_SEARCH_ENGINES,
       IDS_EDIT_SEARCH_ENGINES);
 
+  if (chrome::search::IsInstantExtendedAPIEnabled(
+          location_bar_view_->profile())) {
+    int copy_position = menu_contents->GetIndexOfCommandId(IDS_APP_COPY);
+    DCHECK(copy_position >= 0);
+    menu_contents->InsertItemWithStringIdAt(
+        copy_position + 1, IDC_COPY_URL, IDS_COPY_URL);
+  }
+
   int paste_position = menu_contents->GetIndexOfCommandId(IDS_APP_PASTE);
-  if (paste_position >= 0)
-    menu_contents->InsertItemWithStringIdAt(
-        paste_position + 1, IDS_PASTE_AND_GO, IDS_PASTE_AND_GO);
+  DCHECK(paste_position >= 0);
+  menu_contents->InsertItemWithStringIdAt(
+      paste_position + 1, IDS_PASTE_AND_GO, IDS_PASTE_AND_GO);
 }
 
 bool OmniboxViewViews::IsCommandIdEnabled(int command_id) const {
-  return (command_id == IDS_PASTE_AND_GO) ?
-      model()->CanPasteAndGo(GetClipboardText()) :
-      command_updater()->IsCommandEnabled(command_id);
+  if (command_id == IDS_PASTE_AND_GO) {
+    return model()->CanPasteAndGo(GetClipboardText());
+  } else if (command_id == IDS_COPY_URL) {

[Peter Kasting, 2012/09/11 21:52:59]

Nit: No else after return.

[dominich, 2012/09/12 15:23:09]

Done.

+    return toolbar_model()->WouldReplaceSearchURLWithSearchTerms() &&
+      !model()->user_input_in_progress();
+  }
+  return command_updater()->IsCommandEnabled(command_id);
 }
 
 bool OmniboxViewViews::IsItemForCommandIdDynamic(int command_id) const {
   return command_id == IDS_PASTE_AND_GO;
 }
 
 string16 OmniboxViewViews::GetLabelForCommandId(int command_id) const {
   if (command_id == IDS_PASTE_AND_GO) {
     return l10n_util::GetStringUTF16(
         model()->IsPasteAndSearch(GetClipboardText()) ?
         IDS_PASTE_AND_SEARCH : IDS_PASTE_AND_GO);
   }
 
   return string16();
 }
 
 void OmniboxViewViews::ExecuteCommand(int command_id) {
-  if (command_id == IDS_PASTE_AND_GO) {
+  if (command_id == IDS_PASTE_AND_GO)
     model()->PasteAndGo(GetClipboardText());
-    return;
-  }
-
-  command_updater()->ExecuteCommand(command_id);
+  else if (command_id == IDS_COPY_URL)
+    CopyURL();
+  else
+    command_updater()->ExecuteCommand(command_id);
 }
 
 #if defined(OS_CHROMEOS)
 void OmniboxViewViews::CandidateWindowOpened(
       chromeos::input_method::InputMethodManager* manager) {
   ime_candidate_window_open_ = true;
   CloseOmniboxPopup();
 }
 
 void OmniboxViewViews::CandidateWindowClosed(
@@ skipping 54 matching lines @@
                                                const ui::Range& range) {
   if (text != GetText())
     textfield_->SetText(text);
   textfield_->SelectRange(range);
 }
 
 string16 OmniboxViewViews::GetSelectedText() const {
   // TODO(oshima): Support instant, IME.
   return textfield_->GetSelectedText();
 }
+
+void OmniboxViewViews::CopyURL() {
+  BookmarkNodeData data;
+  const string16& text = toolbar_model()->GetText(false);
+  data.ReadFromTuple(toolbar_model()->GetURL(), text);
+  DoCopy(text, &data);
+}