Add Copy URL option to Omnibox context menu when URL is replaced by Instant Extended.

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
@@ skipping 807 matching lines @@
   return selection.length > 0;
 }
 
 void OmniboxViewMac::CopyToPasteboard(NSPasteboard* pb) {
   DCHECK(CanCopy());
 
   const NSRange selection = GetSelectedRange();
   string16 text = base::SysNSStringToUTF16(
       [[field_ stringValue] substringWithRange:selection]);
 
+  // Copy the URL unless this is the search URL and it's being replaced by the
+  // Extended Instant API.
   GURL url;
   bool write_url = false;
-  model()->AdjustTextForCopy(selection.location, IsSelectAll(), &text, &url,
-                            &write_url);
+  if (!ShouldAddCopyURL()) {
+    model()->AdjustTextForCopy(selection.location, IsSelectAll(), &text, &url,
+                               &write_url);
+  }
 
   NSString* nstext = base::SysUTF16ToNSString(text);
   [pb declareTypes:[NSArray arrayWithObject:NSStringPboardType] owner:nil];
   [pb setString:nstext forType:NSStringPboardType];
 
   if (write_url) {
     [pb declareURLPasteboardWithAdditionalTypes:[NSArray array] owner:nil];
     [pb setDataForURL:base::SysUTF8ToNSString(url.spec()) title:nstext];
   }
 }
 
+void OmniboxViewMac::CopyURLToPasteboard(NSPasteboard* pb) {
+  DCHECK(CanCopy());
+  DCHECK(ShouldAddCopyURL());
+
+  string16 text = toolbar_model()->GetText(false);
+  GURL url = toolbar_model()->GetURL();
+
+  NSString* nstext = base::SysUTF16ToNSString(text);
+  [pb declareTypes:[NSArray arrayWithObject:NSStringPboardType] owner:nil];
+  [pb setString:nstext forType:NSStringPboardType];
+
+  [pb declareURLPasteboardWithAdditionalTypes:[NSArray array] owner:nil];
+  [pb setDataForURL:base::SysUTF8ToNSString(url.spec()) title:nstext];
+}
+
 void OmniboxViewMac::OnPaste() {
   // This code currently expects |field_| to be focussed.
   DCHECK([field_ currentEditor]);
 
   string16 text = GetClipboardText();
   if (text.empty()) {
     return;
   }
   NSString* s = base::SysUTF16ToNSString(text);
 
@@ skipping 12 matching lines @@
     // Force a Paste operation to trigger the text_changed code in
     // OnAfterPossibleChange(), even if identical contents are pasted
     // into the text box.
     text_before_change_.clear();
 
     [editor replaceCharactersInRange:selectedRange withString:s];
     [editor didChangeText];
   }
 }
 
+// TODO(dominich): Move to OmniboxView base class?

[Peter Kasting, 2012/09/11 21:52:59]

Yes (since you use logic identical to this a number of places).  I don't know if
I'd call it "ShouldAddCopyURL()", though, since we now always add that -- maybe
"ShouldEnableCopyURL()".

[dominich, 2012/09/12 15:23:09]

I explained in an earlier revision that it's not a trivial change.
ShouldAddCopyURL (which I should rename) is called on the Observer, which is not
the OmniboxView base class. It's another example of the more complex cocoa class
hierarchy not playing nicely with the other platforms.

It's possible to put this in the OmniboxView base and then call it from an
AutocompleteTextFieldObserver virtual but that doesn't really gain much. 

I'll have a crack in the next CL.

+bool OmniboxViewMac::ShouldAddCopyURL() {
+  return !model()->user_input_in_progress() &&
+      toolbar_model()->WouldReplaceSearchURLWithSearchTerms();
+}
+
 bool OmniboxViewMac::CanPasteAndGo() {
   return model()->CanPasteAndGo(GetClipboardText());
 }
 
 int OmniboxViewMac::GetPasteActionStringId() {
   string16 text(GetClipboardText());
   DCHECK(model()->CanPasteAndGo(text));
   return model()->IsPasteAndSearch(GetClipboardText()) ?
       IDS_PASTE_AND_SEARCH : IDS_PASTE_AND_GO;
 }
@@ skipping 94 matching lines @@
 NSUInteger OmniboxViewMac::GetTextLength() const {
   return ([field_ currentEditor] ?
           [[[field_ currentEditor] string] length] :
           [[field_ stringValue] length]) - suggest_text_length_;
 }
 
 bool OmniboxViewMac::IsCaretAtEnd() const {
   const NSRange selection = GetSelectedRange();
   return selection.length == 0 && selection.location == GetTextLength();
 }