Add Copy URL option to Omnibox context menu when URL is replaced by Instant Extended.

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h"
 
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"  // IDC_*
 #include "chrome/browser/ui/browser_list.h"
@@ skipping 78 matching lines @@
   DCHECK(observer);
   if (observer && observer->CanCopy())
     observer->CopyToPasteboard([NSPasteboard generalPasteboard]);
 }
 
 - (void)cut:(id)sender {
   [self copy:sender];
   [self delete:nil];
 }
 
+- (void)copyURL:(id)sender {
+  AutocompleteTextFieldObserver* observer = [self observer];
+  DCHECK(observer);
+  if (observer->CanCopy())
+    observer->CopyURLToPasteboard([NSPasteboard generalPasteboard]);
+}
+
 // This class assumes that the delegate is an AutocompleteTextField.
 // Enforce that assumption.
 - (AutocompleteTextField*)delegate {
   AutocompleteTextField* delegate =
       static_cast<AutocompleteTextField*>([super delegate]);
   DCHECK(delegate == nil ||
          [delegate isKindOfClass:[AutocompleteTextField class]]);
   return delegate;
 }
 
@@ skipping 92 matching lines @@
   if (actionMenu)
     return actionMenu;
 
   NSMenu* menu = [[[NSMenu alloc] initWithTitle:@"TITLE"] autorelease];
   [menu addItemWithTitle:l10n_util::GetNSStringWithFixup(IDS_CUT)
                   action:@selector(cut:)
            keyEquivalent:@""];
   [menu addItemWithTitle:l10n_util::GetNSStringWithFixup(IDS_COPY)
                   action:@selector(copy:)
            keyEquivalent:@""];
+
+  if ([self isEditable]) {
+    // Copy URL if the URL has been replaced by the Extended Instant API.
+    AutocompleteTextFieldObserver* observer = [self observer];

[dhollowa, 2012/09/11 20:25:34]

|observer| is not used here except in DCHECK.

[dominich, 2012/09/12 15:23:09]

Done.

+    DCHECK(observer);
+    NSString* label = l10n_util::GetNSStringWithFixup(IDS_COPY_URL_MAC);
+    [menu addItemWithTitle:label
+                    action:@selector(copyURL:)
+             keyEquivalent:@""];
+  }
+
   [menu addItemWithTitle:l10n_util::GetNSStringWithFixup(IDS_PASTE)
                   action:@selector(paste:)
            keyEquivalent:@""];
 
   // TODO(shess): If the control is not editable, should we show a
   // greyed-out "Paste and Go"?
   if ([self isEditable]) {
     // Paste and go/search.
     AutocompleteTextFieldObserver* observer = [self observer];
     DCHECK(observer);
-    if (observer && observer->CanPasteAndGo()) {
-      const int string_id = observer->GetPasteActionStringId();
-      NSString* label = l10n_util::GetNSStringWithFixup(string_id);
+    const int string_id = observer->GetPasteActionStringId();
+    NSString* label = l10n_util::GetNSStringWithFixup(string_id);
 
-      // TODO(rohitrao): If the clipboard is empty, should we show a
-      // greyed-out "Paste and Go" or nothing at all?
-      if ([label length]) {
-        [menu addItemWithTitle:label
-                        action:@selector(pasteAndGo:)
-                 keyEquivalent:@""];
-      }
+    if ([label length]) {
+      [menu addItemWithTitle:label
+                      action:@selector(pasteAndGo:)
+               keyEquivalent:@""];
     }
 
-    NSString* label = l10n_util::GetNSStringWithFixup(IDS_EDIT_SEARCH_ENGINES);
-    DCHECK([label length]);
-    if ([label length]) {
+    NSString* search_engine_label =
+        l10n_util::GetNSStringWithFixup(IDS_EDIT_SEARCH_ENGINES);
+    DCHECK([search_engine_label length]);
+    if ([search_engine_label length]) {

[dhollowa, 2012/09/11 20:25:34]

nit: No need to test for same thing as DCHECK.

[Peter Kasting, 2012/09/11 21:52:59]

Nit: Also, be consistent in this function about where you DCHECK versus use a
conditional versus neither.

[dominich, 2012/09/12 15:23:09]

Done.

[dominich, 2012/09/12 15:23:09]

Done.

       [menu addItem:[NSMenuItem separatorItem]];
-      NSMenuItem* item = [menu addItemWithTitle:label
+      NSMenuItem* item = [menu addItemWithTitle:search_engine_label
                                          action:@selector(commandDispatch:)
                                   keyEquivalent:@""];
       [item setTag:IDC_EDIT_SEARCH_ENGINES];
     }
   }
 
   return menu;
 }
 
 // (Overridden from NSResponder)
@@ skipping 215 matching lines @@
 
   // The text has been changed programmatically. The observer should know
   // this change, so setting |textChangedByKeyEvents_| to NO to
   // prevent its OnDidChange() method from being called unnecessarily.
   textChangedByKeyEvents_ = NO;
 }
 
 - (BOOL)validateMenuItem:(NSMenuItem*)item {
   if ([item action] == @selector(copyToFindPboard:))
     return [self selectedRange].length > 0;
+  if ([item action] == @selector(pasteAndGo:)) {
+    // TODO(rohitrao): If the clipboard is empty, should we show a
+    // greyed-out "Paste and Go" or nothing at all?

[Peter Kasting, 2012/09/11 21:52:59]

Nit: Shouldn't this TODO go away?

[dominich, 2012/09/12 15:23:09]

No. I'm not checking the contents of the clipboard.

+    AutocompleteTextFieldObserver* observer = [self observer];
+    DCHECK(observer);
+    return observer->CanPasteAndGo();
+  }
+  if ([item action] == @selector(copyURL:)) {
+    AutocompleteTextFieldObserver* observer = [self observer];
+    DCHECK(observer);
+    return observer->ShouldAddCopyURL();
+  }
   return [super validateMenuItem:item];
 }
 
 - (void)copyToFindPboard:(id)sender {
   NSRange selectedRange = [self selectedRange];
   if (selectedRange.length == 0)
     return;
   NSAttributedString* selection =
       [self attributedSubstringForProposedRange:selectedRange
                                     actualRange:NULL];
   if (!selection)
     return;
 
   [[FindPasteboard sharedInstance] setFindText:[selection string]];
 }
 
 @end