chrome/browser/shell_integration_linux.cc - Issue 10915047: Links in platform apps should open in the system default browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/shell_integration_linux.cc

Issue 10915047: Links in platform apps should open in the system default browser. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: refine the patch. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/shell_integration_linux.h ('k') | chrome/browser/ui/extensions/shell_window.cc » ('j') | chrome/browser/ui/extensions/shell_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/shell_integration_linux.cc

diff --git a/chrome/browser/shell_integration_linux.cc b/chrome/browser/shell_integration_linux.cc

index ea05095b793ee2aac3f6ef78dc0e199dd9c30c5c..71ef1617666e5b97591f219341a6ad9ecc70ca49 100644

--- a/chrome/browser/shell_integration_linux.cc

+++ b/chrome/browser/shell_integration_linux.cc

@@ -688,4 +688,13 @@ void DeleteDesktopShortcuts(const FilePath& profile_path,

DeleteShortcutInApplicationsMenu(shortcut_filename);

}

+void LaunchDefaultBrowser(const GURL& url) {

Mihai Parparita -not on Chrome 2012/09/04 21:39:53 This is already implemented (for all platforms) by

+ std::vector<std::string> argv;

+ argv.push_back("xdg-open");

+ argv.push_back(url.spec().c_str());

+ int exit_code;

+ LaunchXdgUtility(argv, &exit_code);

} // namespace ShellIntegrationLinux

« no previous file with comments | « chrome/browser/shell_integration_linux.h ('k') | chrome/browser/ui/extensions/shell_window.cc » ('j') | chrome/browser/ui/extensions/shell_window.cc » ('J')