chrome/browser/extensions/platform_app_browsertest.cc - Issue 10915047: Links in platform apps should open in the system default browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/platform_app_browsertest.cc

Issue 10915047: Links in platform apps should open in the system default browser. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Adjust the test case and functionality for Open Link. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/platform_app_browsertest.cc

diff --git a/chrome/browser/extensions/platform_app_browsertest.cc b/chrome/browser/extensions/platform_app_browsertest.cc

index 50165a1710d68971ebb90e5b935b377e93d79a05..d9c174e55d0b3b633aaa05a707526d5aed138e8d 100644

--- a/chrome/browser/extensions/platform_app_browsertest.cc

+++ b/chrome/browser/extensions/platform_app_browsertest.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include "base/bind.h"

+#include "base/command_line.h"

#include "base/test/test_timeouts.h"

#include "base/threading/platform_thread.h"

#include "base/utf_string_conversions.h"

@@ -488,6 +489,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, GetDisplayPath) {

#endif // defined(OS_CHROMEOS)

IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, OpenLink) {

+ ClearCommandLineArgs();

+ CommandLine::ForCurrentProcess()->AppendSwitch("OpenLinkTest");

ASSERT_TRUE(StartTestServer());

content::WindowedNotificationObserver observer(

chrome::NOTIFICATION_TAB_ADDED,

« no previous file with comments | « no previous file | chrome/browser/ui/extensions/shell_window.cc » ('j') | chrome/browser/ui/extensions/shell_window.cc » ('J')