Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 10914327: Make cc's use of WTF::HashMap robust to key/value change (Closed)

Created:
8 years, 3 months ago by enne (OOO)
Modified:
8 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Make cc's use of WTF::HashMap robust to key/value change A future WebKit change (bug 82784) plans to change HashMap iterator's first/second to key/value. Since cc is still (unfortunately) using WebKit's WTF template classes, be robust to this patch landing with an #ifdef. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -39 lines) Patch
M cc/CCDamageTracker.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/CCDirectRenderer.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M cc/CCLayerTilingData.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/CCLayerTreeHost.cpp View 3 chunks +12 lines, -0 lines 0 comments Download
M cc/CCLayerTreeHostImpl.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/CCResourceProvider.cpp View 17 chunks +125 lines, -39 lines 0 comments Download
M cc/TiledLayerChromium.cpp View 5 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
Assuming "#define WTF_NEW_HASHMAP_ITERATORS_INTERFACE 1" is added to the WebKit patch, this change compiles with that ...
8 years, 3 months ago (2012-09-17 23:21:59 UTC) #1
jamesr
lgtm That wasn't so bad. Can you ask on the upstream bug for that #define ...
8 years, 3 months ago (2012-09-17 23:24:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/10914327/1
8 years, 3 months ago (2012-09-17 23:26:03 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-17 23:30:17 UTC) #4
jamesr
8 years, 3 months ago (2012-09-17 23:30:46 UTC) #5
On 2012/09/17 23:30:17, I haz the power (commit-bot) wrote:
> Step "update" is always a major failure.
> Look at the try server FAQ for more details.

2>svn: Can't close file '.svn\tmp\entries': There is not enough space on the
disk. 

>:{

Powered by Google App Engine
This is Rietveld 408576698