chrome/common/extensions/api/page_action.json - Issue 10914244: Remove support for page_action.icons, and the legacy code surrounding it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/page_action.json

Issue 10914244: Remove support for page_action.icons, and the legacy code surrounding it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: docs Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc ('K') | « chrome/browser/ui/views/location_bar/page_action_image_view.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/page_action.json

diff --git a/chrome/common/extensions/api/page_action.json b/chrome/common/extensions/api/page_action.json

index 9530e8c8946daae8ea6854406ff39f52f4f9b45c..513f4ddc4f290720fc4f2c63b08491c9ca846263 100644

--- a/chrome/common/extensions/api/page_action.json

+++ b/chrome/common/extensions/api/page_action.json

@@ -115,7 +115,7 @@

"iconIndex": {

"type": "integer",

"minimum": 0,

- "description": "Deprecated. The zero-based index into the icons vector specified in the manifest.",

+ "description": "Deprecated. This argument is ignored.",

"optional": true

}