Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 10914231: Map fullscreen button to maximize (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 5ec623ea018a6d46fcc4b00c5c0793af9d8e6c6d..8f3ab2e6ccc459098a6ad6f0599bd11aacc1fb0f 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -136,14 +136,14 @@ bool BrowserCommandController::IsReservedCommandOrKey(
#if defined(OS_CHROMEOS)
// Chrome OS's top row of keys produces F1-10. Make sure that web pages
// aren't able to block Chrome from performing the standard actions for F1-F4.
- // We should not handle F5-10 here since they are processed by Ash. See also:
+ // We should not handle F4-10 here since they are processed by Ash. See also:
// crbug.com/127333#c8
+ // crbug.com/145402 for removing VKEY_F4
ui::KeyboardCode key_code =
static_cast<ui::KeyboardCode>(event.windowsKeyCode);
if ((key_code == ui::VKEY_F1 ||
key_code == ui::VKEY_F2 ||
- key_code == ui::VKEY_F3 ||
- key_code == ui::VKEY_F4) &&
+ key_code == ui::VKEY_F3) &&
// Make sure it's a browser shortcut (i.e. not an Ash one like Alt+F4).
command_id != -1) {
return true;

Powered by Google App Engine
This is Rietveld 408576698