Map fullscreen button to maximize

chrome/browser/ui/views/accelerator_table_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 
 #include "base/basictypes.h"
 #include "chrome/browser/ui/views/accelerator_table.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/events/event_constants.h"
@@ skipping 25 matching lines @@
     EXPECT_TRUE(acclerators.insert(entry).second)
         << "Duplicated accelerator: " << entry.keycode << ", "
         << (entry.modifiers & ui::EF_SHIFT_DOWN) << ", "
         << (entry.modifiers & ui::EF_CONTROL_DOWN) << ", "
         << (entry.modifiers & ui::EF_ALT_DOWN);
   }
 }
 
 #if defined(USE_ASH)
 TEST(AcceleratorTableTest, CheckDuplicatedAcceleratorsAsh) {
+  std::set<AcceleratorMapping, Cmp> allowed_duplicates;
+#if defined(OS_CHROMEOS)
+  AcceleratorMapping exception_entry;
+  exception_entry.keycode = ui::VKEY_F4; // F4 has Ash and Chrome shortcuts

[sky, 2012/09/16 16:08:03]

This comment is better placed above this line:
// Both chrome and Ash have a shortcut for F4.

[sschmitz, 2012/09/17 15:22:05]

Done.

+  exception_entry.modifiers = ui::EF_NONE;
+  exception_entry.command_id = 0;  // dummy
+  allowed_duplicates.insert(exception_entry);
+#endif
+
   std::set<AcceleratorMapping, Cmp> acclerators;
   for (size_t i = 0; i < kAcceleratorMapLength; ++i) {
     const AcceleratorMapping& entry = kAcceleratorMap[i];
     acclerators.insert(entry);
   }
   for (size_t i = 0; i < ash::kAcceleratorDataLength; ++i) {
     const ash::AcceleratorData& ash_entry = ash::kAcceleratorData[i];
     if (!ash_entry.trigger_on_press)
       continue;  // kAcceleratorMap does not have any release accelerators.
     AcceleratorMapping entry;
     entry.keycode = ash_entry.keycode;
     entry.modifiers = ash_entry.modifiers;
     entry.command_id = 0;  // dummy
-    EXPECT_TRUE(acclerators.insert(entry).second)
-        << "Duplicated accelerator: " << entry.keycode << ", "
-        << (entry.modifiers & ui::EF_SHIFT_DOWN) << ", "
-        << (entry.modifiers & ui::EF_CONTROL_DOWN) << ", "
-        << (entry.modifiers & ui::EF_ALT_DOWN);
+    if (allowed_duplicates.find(entry) == allowed_duplicates.end()) {
+      EXPECT_TRUE(acclerators.insert(entry).second)
+          << "Duplicated accelerator: " << entry.keycode << ", "
+          << (entry.modifiers & ui::EF_SHIFT_DOWN) << ", "
+          << (entry.modifiers & ui::EF_CONTROL_DOWN) << ", "
+          << (entry.modifiers & ui::EF_ALT_DOWN);
+    }
   }
 }
 #endif  // USE_ASH
 
 }  // namespace chrome