Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: media/base/channel_layout.h

Issue 10914203: Add UMA reporting for audio hardware parameters. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/audio/audio_output_resampler.cc ('K') | « media/audio/sample_rates.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/channel_layout.h
diff --git a/media/base/channel_layout.h b/media/base/channel_layout.h
index 9e884204177b92336ec0dda96093144d001d98f6..dc3bdad2a2c20f6d09c1ffa9d101c5d0f1895acc 100644
--- a/media/base/channel_layout.h
+++ b/media/base/channel_layout.h
@@ -8,56 +8,57 @@
#include "media/base/media_export.h"
enum ChannelLayout {
+ // Do not change the order of these values.
scherkus (not reviewing) 2012/09/12 13:34:50 can you elaborate / mention UMA? Instead of copyi
DaleCurtis 2012/09/12 14:03:52 Done.
CHANNEL_LAYOUT_NONE = 0,
- CHANNEL_LAYOUT_UNSUPPORTED,
+ CHANNEL_LAYOUT_UNSUPPORTED = 1,
// Front C
- CHANNEL_LAYOUT_MONO,
+ CHANNEL_LAYOUT_MONO = 2,
// Front L, Front R
- CHANNEL_LAYOUT_STEREO,
+ CHANNEL_LAYOUT_STEREO = 3,
// Front L, Front R, Back C
- CHANNEL_LAYOUT_2_1,
+ CHANNEL_LAYOUT_2_1 = 4,
// Front L, Front R, Front C
- CHANNEL_LAYOUT_SURROUND,
+ CHANNEL_LAYOUT_SURROUND = 5,
// Front L, Front R, Front C, Back C
- CHANNEL_LAYOUT_4_0,
+ CHANNEL_LAYOUT_4_0 = 6,
// Front L, Front R, Side L, Side R
- CHANNEL_LAYOUT_2_2,
+ CHANNEL_LAYOUT_2_2 = 7,
// Front L, Front R, Back L, Back R
- CHANNEL_LAYOUT_QUAD,
+ CHANNEL_LAYOUT_QUAD = 8,
// Front L, Front R, Front C, Side L, Side R
- CHANNEL_LAYOUT_5_0,
+ CHANNEL_LAYOUT_5_0 = 9,
// Front L, Front R, Front C, Side L, Side R, LFE
- CHANNEL_LAYOUT_5_1,
+ CHANNEL_LAYOUT_5_1 = 10,
// Front L, Front R, Front C, Back L, Back R
- CHANNEL_LAYOUT_5_0_BACK,
+ CHANNEL_LAYOUT_5_0_BACK = 11,
// Front L, Front R, Front C, Back L, Back R, LFE
- CHANNEL_LAYOUT_5_1_BACK,
+ CHANNEL_LAYOUT_5_1_BACK = 12,
// Front L, Front R, Front C, Side L, Side R, Back L, Back R
- CHANNEL_LAYOUT_7_0,
+ CHANNEL_LAYOUT_7_0 = 13,
// Front L, Front R, Front C, Side L, Side R, LFE, Back L, Back R
- CHANNEL_LAYOUT_7_1,
+ CHANNEL_LAYOUT_7_1 = 14,
// Front L, Front R, Front C, Back L, Back R, LFE, Front LofC, Front RofC
- CHANNEL_LAYOUT_7_1_WIDE,
+ CHANNEL_LAYOUT_7_1_WIDE = 15,
// Stereo L, Stereo R
- CHANNEL_LAYOUT_STEREO_DOWNMIX,
+ CHANNEL_LAYOUT_STEREO_DOWNMIX = 16,
// Total number of layouts.
- CHANNEL_LAYOUT_MAX
+ CHANNEL_LAYOUT_MAX // Must always be last!
};
enum Channels {
« media/audio/audio_output_resampler.cc ('K') | « media/audio/sample_rates.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698