Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 10914178: Adds media::AudioPullFifo class to Chrome. (Closed)

Created:
8 years, 3 months ago by scherkus (not reviewing)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Adds media::AudioPullFifo class to Chrome. A FIFO (First In First Out) buffer to handle mismatches in buffer sizes between a provider and consumer. The consumer will pull data from this FIFO. If data is already available in the FIFO, it is provided to the consumer. If insufficient data is available to satisfy the request, the FIFO will ask the provider for more data to fulfill a request. Patch by henrika@chromium.org: http://codereview.chromium.org/10915123/ BUG=none TEST=--gtest_filter=AudioPullFifoTest.* TBR=henrika Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -101 lines) Patch
M media/base/audio_fifo.h View 1 chunk +11 lines, -11 lines 0 comments Download
M media/base/audio_fifo.cc View 3 chunks +16 lines, -24 lines 0 comments Download
M media/base/audio_fifo_unittest.cc View 8 chunks +46 lines, -66 lines 0 comments Download
A media/base/audio_pull_fifo.h View 1 chunk +62 lines, -0 lines 0 comments Download
A media/base/audio_pull_fifo.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A media/base/audio_pull_fifo_unittest.cc View 1 chunk +89 lines, -0 lines 0 comments Download
M media/media.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
8 years, 3 months ago (2012-09-10 16:14:49 UTC) #1
henrika (OOO until Aug 14)
8 years, 3 months ago (2012-09-10 16:16:57 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698