Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 10914147: Manage ChromeToMobile URLFetcher lifetimes with a ScopedVector. (Closed)

Created:
8 years, 3 months ago by msw
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Manage ChromeToMobile URLFetcher lifetimes with a ScopedVector. TBR=sky@chromium.org,rsimha@chromium.org BUG=146826 TEST=Automated tests no longer fail with leaked URLFetchers. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/chrome_to_mobile_service.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
msw
Please take a look; thanks!
8 years, 3 months ago (2012-09-07 15:46:09 UTC) #1
erikwright (departed)
On 2012/09/07 15:46:09, msw wrote: > Please take a look; thanks! In general, this seems ...
8 years, 3 months ago (2012-09-07 15:50:56 UTC) #2
msw
On 2012/09/07 15:50:56, erikwright wrote: > On 2012/09/07 15:46:09, msw wrote: > > Please take ...
8 years, 3 months ago (2012-09-07 15:52:53 UTC) #3
erikwright (departed)
LGTM.
8 years, 3 months ago (2012-09-07 15:59:45 UTC) #4
msw
TBR'ed sky and rsimha, sending to the CQ to green up the tree.
8 years, 3 months ago (2012-09-07 16:04:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10914147/1
8 years, 3 months ago (2012-09-07 16:06:40 UTC) #6
commit-bot: I haz the power
Change committed as 155417
8 years, 3 months ago (2012-09-07 17:45:56 UTC) #7
rsimha_google_not_chromium
8 years, 3 months ago (2012-09-07 21:17:28 UTC) #8
LGTM. Thanks for the fix!

Powered by Google App Engine
This is Rietveld 408576698