Prime the Windows theme DLL earlier.

content/app/content_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/app/content_main_runner.h"
 
 #include <stdlib.h>
 
 #include "base/allocator/allocator_extension.h"
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/debug/trace_event.h"
 #include "base/file_path.h"
 #include "base/i18n/icu_util.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/stats_table.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/profiler/alternate_timer.h"
+#include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/string_number_conversions.h"
 #include "content/browser/browser_main.h"
 #include "content/common/set_process_title.h"
 #include "content/common/url_schemes.h"
 #include "content/public/app/content_main_delegate.h"
 #include "content/public/app/startup_helper_win.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_constants.h"
@@ skipping 15 matching lines @@
 
 #if defined(USE_TCMALLOC)
 #include "third_party/tcmalloc/chromium/src/gperftools/malloc_extension.h"
 #endif
 
 #if defined(OS_WIN)
 #include <cstring>
 #include <atlbase.h>
 #include <atlapp.h>
 #include <malloc.h>
+#include <string>
 #elif defined(OS_MACOSX)
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "base/mach_ipc_mac.h"
 #include "base/system_monitor/system_monitor.h"
 #include "content/browser/mach_broker_mac.h"
 #include "content/common/sandbox_init_mac.h"
 #endif  // OS_WIN
 
 #if defined(OS_POSIX)
 #include <signal.h>
@@ skipping 20 matching lines @@
 extern int RendererMain(const content::MainFunctionParams&);
 extern int WorkerMain(const content::MainFunctionParams&);
 extern int UtilityMain(const content::MainFunctionParams&);
 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_ANDROID)
 namespace content {
 extern int ZygoteMain(const MainFunctionParams&,
                       ZygoteForkDelegate* forkdelegate);
 }  // namespace content
 #endif
 
+namespace {
+#if defined(OS_WIN)
+// In order to have Theme support, we need to connect to the theme service.
+// This needs to be done before we lock down the renderer. Officially this
+// can be done with OpenThemeData() but it fails unless you pass a valid
+// window at least the first time. Interestingly, the very act of creating a
+// window also sets the connection to the theme service.
+void EnableThemeSupportForRenderer() {
+  HWINSTA current_station = ::GetProcessWindowStation();
+  static const size_t kStaticBufferLength = 32;
+  char static_buffer[kStaticBufferLength];
+  static_buffer[0] = '\0';

[robertshield, 2012/09/06 18:35:56]

char static_buffer[kStaticBufferLength] = "";

[MAD, 2012/09/06 23:57:53]

Done.

+  const char * current_station_name = static_buffer;

[robertshield, 2012/09/06 18:35:56]

nit: const char* current_station_name = static_buffer;

[MAD, 2012/09/06 23:57:53]

Done.

+  // In case our static buffer isn't big enough, we'll use this dynamic one that
+  // will be holding on the allocated char buffer long enough.
+  std::string dynamic_buffer;

[robertshield, 2012/09/06 18:35:56]

Couldn't we simplify this by always using dynamic_buffer? Initialize
dynamic_buffer to an empty string of length kStaticBufferLength:
std::string dynamic_buffer('\0', kStaticBufferLength);

[MAD, 2012/09/06 23:57:53]

Done.

+  DWORD needed_length = 0;
+  if (!::GetUserObjectInformationA(current_station,
+                                   UOI_NAME,
+                                   static_buffer,
+                                   kStaticBufferLength,
+                                   &needed_length)) {
+    DCHECK(needed_length > kStaticBufferLength) << " Windows error: "
+                                                << ::GetLastError();
+    dynamic_buffer.resize(needed_length);
+    if (!::GetUserObjectInformationA(
+        current_station,
+        UOI_NAME,
+        const_cast<char*>(dynamic_buffer.c_str()),

[rvargas (doing something else), 2012/09/06 23:19:21]

WriteInto ?

+        needed_length,
+        &needed_length)) {
+      NOTREACHED() << "Windows error: " << ::GetLastError();
+    }
+    current_station_name = dynamic_buffer.c_str();
+  }
+
+  if (base::strncasecmp(current_station_name, "WinSta0", 7)) {
+    HWINSTA winsta0 = NULL;
+    winsta0 = ::OpenWindowStationA("WinSta0", FALSE, GENERIC_READ);

[robertshield, 2012/09/06 18:35:56]

shorten this to HWINSTA winsta0 = ::OpenWindowStationA("WinSta0", FALSE,
GENERIC_READ);

[MAD, 2012/09/06 23:57:53]

Done.

+    if (!winsta0 || !::SetProcessWindowStation(winsta0)) {
+      // Could not set the alternate window station. There is a possibility
+      // that the theme wont be correctly initialized.
+      NOTREACHED() << "Unable to switch to WinSta0, we: "<< ::GetLastError();
+    }
+
+    HWND window = ::CreateWindowExW(0, L"Static", L"", WS_POPUP | WS_DISABLED,
+                                    CW_USEDEFAULT, 0, 0, 0,  HWND_MESSAGE, NULL,
+                                    ::GetModuleHandleA(NULL), NULL);
+    if (!window) {
+      DLOG(WARNING) << "failed to enable theme support";
+    } else {
+      ::DestroyWindow(window);
+      window = NULL;
+    }
+
+    // Revert the window station.
+    if (!current_station || !::SetProcessWindowStation(current_station)) {

[robertshield, 2012/09/06 18:35:56]

is it possible to get here if current_station is NULL?

[MAD, 2012/09/06 23:57:53]

Done.

+      // We failed to switch back to the secure window station. This might
+      // confuse the renderer enough that we should kill it now.
+      LOG(FATAL) << "Failed to restore alternate window station";
+    }
+
+    if (!::CloseWindowStation(winsta0)) {
+      // We might be leaking a winsta0 handle.  This is a security risk, but
+      // since we allow fail over to no desktop protection in low memory
+      // condition, this is not a big risk.
+      NOTREACHED();
+    }
+  }
+}
+#endif  // defined(OS_WIN)
+}  // namespace
+
 namespace content {
 
 base::LazyInstance<ContentBrowserClient>
     g_empty_content_browser_client = LAZY_INSTANCE_INITIALIZER;
 base::LazyInstance<ContentPluginClient>
     g_empty_content_plugin_client = LAZY_INSTANCE_INITIALIZER;
 base::LazyInstance<ContentRendererClient>
     g_empty_content_renderer_client = LAZY_INSTANCE_INITIALIZER;
 base::LazyInstance<ContentUtilityClient>
     g_empty_content_utility_client = LAZY_INSTANCE_INITIALIZER;
@@ skipping 448 matching lines @@
         (delegate &&
          delegate->ProcessRegistersWithSystemProcess(process_type))) {
       base::SystemMonitor::AllocateSystemIOPorts();
     }
 
     if (!process_type.empty() &&
         (!delegate || delegate->ShouldSendMachPort(process_type))) {
       SendTaskPortToParentProcess();
     }
 #elif defined(OS_WIN)
+    // This must be done early enough since some helper functions like
+    // IsTouchEnanble, needed to load ressources, may call into the theme dll.

[robertshield, 2012/09/06 18:35:56]

*IsTouchEnabled, *resources

[MAD, 2012/09/06 23:57:53]

Done.

+    if (process_type == switches::kRendererProcess)
+      EnableThemeSupportForRenderer();
 #if defined(ENABLE_HIDPI)
     ui::EnableHighDPISupport();
 #endif
     SetupCRT(command_line);
 #endif
 
 #if defined(OS_POSIX)
     if (!process_type.empty()) {
       // When you hit Ctrl-C in a terminal running the browser
       // process, a SIGINT is delivered to the entire process group.
@@ skipping 133 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
 };
 
 // static
 ContentMainRunner* ContentMainRunner::Create() {
   return new ContentMainRunnerImpl();
 }
 
 }  // namespace content