Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method.

chrome/installer/setup/install.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/install.h"
 
 #include <shlobj.h>
 #include <time.h>
 #include <winuser.h>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
+#include "base/win/shortcut.h"
 #include "base/win/windows_version.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/installer/setup/setup_constants.h"
 #include "chrome/installer/setup/install_worker.h"
 #include "chrome/installer/util/auto_launch_util.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/create_reg_key_work_item.h"
 #include "chrome/installer/util/delete_after_reboot_helper.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/helper.h"
@@ skipping 272 matching lines @@
           chrome_link.value(), string16(), product_desc, chrome_exe.value(),
           browser_dist->GetIconIndex(), options)) {
     LOG(WARNING) << operation << " shortcut at " << chrome_link.value()
                  << " failed.";
   } else if (create_always &&
              base::win::GetVersion() >= base::win::VERSION_WIN7) {
     // If the Start Menu shortcut was successfully created and |create_always|,
     // proceed to pin the Start Menu shortcut to the taskbar on Win7+.
     VLOG(1) << "Pinning new shortcut at " << chrome_link.value()
             << " to taskbar";
-    if (!file_util::TaskbarPinShortcutLink(chrome_link.value().c_str())) {
+    if (!base::win::TaskbarPinShortcutLink(chrome_link.value().c_str())) {
       LOG(ERROR) << "Failed to pin shortcut to taskbar: "
                  << chrome_link.value();
     }
   }
 
   // Create/update uninstall link if we are not an MSI install. MSI
   // installations are, for the time being, managed only through the
   // Add/Remove Programs dialog.
   // TODO(robertshield): We could add a shortcut to msiexec /X {GUID} here.
   if (!installer_state.is_msi()) {
     // Uninstall Chrome link
     FilePath uninstall_link(start_menu_folder_path.Append(
         browser_dist->GetUninstallLinkName() + L".lnk"));
 
     CommandLine arguments(CommandLine::NO_PROGRAM);
     AppendUninstallCommandLineFlags(installer_state, product, &arguments);
     VLOG(1) << operation << " uninstall link at " << uninstall_link.value();
-    if (!file_util::CreateOrUpdateShortcutLink(setup_exe.value().c_str(),
-            uninstall_link.value().c_str(), NULL,
-            arguments.GetCommandLineString().c_str(), NULL,
-            setup_exe.value().c_str(), 0, NULL,
-            create_always ? file_util::SHORTCUT_CREATE_ALWAYS :
-                            file_util::SHORTCUT_NO_OPTIONS)) {
+    base::win::ShortcutProperties shortcut_properties;
+    shortcut_properties.set_target(setup_exe);
+    shortcut_properties.set_arguments(arguments.GetCommandLineString());
+    shortcut_properties.set_icon(setup_exe, 0);
+    if (!base::win::CreateOrUpdateShortcutLink(
+            uninstall_link, shortcut_properties,
+            create_always ? base::win::SHORTCUT_CREATE_ALWAYS :
+                            base::win::SHORTCUT_UPDATE_EXISTING)) {
       LOG(WARNING) << operation << " uninstall link at "
                    << uninstall_link.value() << " failed.";
     }
   }
 }
 
 void CreateOrUpdateDesktopAndQuickLaunchShortcuts(
     const InstallerState& installer_state,
     const Product& product,
     uint32 options) {
@@ skipping 217 matching lines @@
     uint32 shortcut_options = ShellUtil::SHORTCUT_DUAL_MODE;
     CreateOrUpdateDesktopAndQuickLaunchShortcuts(
         installer_state, chrome, shortcut_options);
     CreateOrUpdateStartMenuAndTaskbarShortcuts(
         installer_state, setup_exe, chrome, shortcut_options);
     RegisterChromeOnMachine(installer_state, chrome, false);
   }
 }
 
 }  // namespace installer