Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method.

base/test/test_file_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TEST_TEST_FILE_UTIL_H_
 #define BASE_TEST_TEST_FILE_UTIL_H_
 
 // File utility functions used only by tests.
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
+#include "base/file_util.h"
 
 class FilePath;
 
 namespace file_util {
 
+#if defined(OS_WIN)
+  enum VerifyShortcutStatus {
+    VERIFY_SHORTCUT_SUCCESS = 0,
+    VERIFY_SHORTCUT_FAILURE_UNEXPECTED,
+    VERIFY_SHORTCUT_FAILURE_FILE_NOT_FOUND,
+    VERIFY_SHORTCUT_FAILURE_TARGET,
+    VERIFY_SHORTCUT_FAILURE_WORKING_DIR,
+    VERIFY_SHORTCUT_FAILURE_ARGUMENTS,
+    VERIFY_SHORTCUT_FAILURE_DESCRIPTION,
+    VERIFY_SHORTCUT_FAILURE_ICON,
+    VERIFY_SHORTCUT_FAILURE_APP_ID,
+    VERIFY_SHORTCUT_FAILURE_DUAL_MODE,
+  };
+#endif  // defined(OS_WIN)
+
 // Wrapper over file_util::Delete. On Windows repeatedly invokes Delete in case
 // of failure to workaround Windows file locking semantics. Returns true on
 // success.
 bool DieFileDie(const FilePath& file, bool recurse);
 
 // Clear a specific file from the system cache. After this call, trying
 // to access this file will result in a cold load from the hard drive.
 bool EvictFileFromSystemCache(const FilePath& file);
 
 // Like CopyFileNoCache but recursively copies all files and subdirectories
 // in the given input directory to the output directory. Any files in the
 // destination that already exist will be overwritten.
 //
 // Returns true on success. False means there was some error copying, so the
 // state of the destination is unknown.
 bool CopyRecursiveDirNoCache(const FilePath& source_dir,
                              const FilePath& dest_dir);
 
 #if defined(OS_WIN)
+// Verify that a shortcut exists at |shortcut_path| with the expected
+// |properties|.
+VerifyShortcutStatus VerifyShortcut(const string16& shortcut_path,
+                                    const ShortcutProperties& properties);
+
 // Returns true if the volume supports Alternate Data Streams.
 bool VolumeSupportsADS(const FilePath& path);
 
 // Returns true if the ZoneIdentifier is correctly set to "Internet" (3).
 // Note that this function must be called from the same process as
 // the one that set the zone identifier.  I.e. don't use it in UI/automation
 // based tests.
 bool HasInternetZoneIdentifier(const FilePath& full_path);
 #endif  // defined(OS_WIN)
 
@@ skipping 18 matching lines @@
   const FilePath path_;
   void* info_;  // The opaque stored permission information.
   size_t length_;  // The length of the stored permission information.
 
   DISALLOW_COPY_AND_ASSIGN(PermissionRestorer);
 };
 
 }  // namespace file_util
 
 #endif  // BASE_TEST_TEST_FILE_UTIL_H_