Refine systemInfo.cpu API defintions and provide systemInfo.cpu.get impl for Windows and Linux

base/sys_info_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sys_info.h"
 
 #include <ApplicationServices/ApplicationServices.h>
 #include <CoreServices/CoreServices.h>
 #include <mach/mach_host.h>
 #include <mach/mach_init.h>
+#include <sys/sysctl.h>
+#include <sys/types.h>
 
 #include "base/logging.h"
 #include "base/stringprintf.h"
 
 namespace base {
 
 // static
 std::string SysInfo::OperatingSystemName() {
   return "Mac OS X";
 }
@@ skipping 26 matching lines @@
                          reinterpret_cast<host_info_t>(&hostinfo),
                          &count);
   if (result != KERN_SUCCESS) {
     NOTREACHED();
     return 0;
   }
   DCHECK_EQ(HOST_BASIC_INFO_COUNT, count);
   return static_cast<int64>(hostinfo.max_mem);
 }
 
+// static
+std::string SysInfo::CPUModelName() {
+  char model_name[256] = { 0 };

[Mark Mentovai, 2012/09/06 14:17:56]

You don’t need the { 0 } at all It’s fine to leave this uninitialized because
you should be checking the return value from sysctlbyname.

[Hongbo Min, 2012/09/06 14:33:45]

Done.

+  size_t len = 256;

[Mark Mentovai, 2012/09/06 14:17:56]

Not 256, but arraysize(model_name).

[Hongbo Min, 2012/09/06 14:33:45]

Done.

+  sysctlbyname("machdep.cpu.brand_string", &model_name, &len, NULL, 0);

[Mark Mentovai, 2012/09/06 14:17:56]

You should check the return value, and return an empty string when it’s nonzero.

[Hongbo Min, 2012/09/06 14:33:45]

Done.

+  return std::string(model_name);
+}
+
 }  // namespace base