 Chromium Code Reviews
 Chromium Code Reviews Issue 10913277:
  Upstream ContentViewCore.pageUp/pageDown  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 10913277:
  Upstream ContentViewCore.pageUp/pageDown  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: content/public/android/java/src/org/chromium/content/browser/SelectionHandleController.java | 
| diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionHandleController.java b/content/public/android/java/src/org/chromium/content/browser/SelectionHandleController.java | 
| index 8e6b0bf39fe7d4eb3da81e06e5ab337a0036da3d..18200384bff050ba072c8ebcde252659d5468256 100644 | 
| --- a/content/public/android/java/src/org/chromium/content/browser/SelectionHandleController.java | 
| +++ b/content/public/android/java/src/org/chromium/content/browser/SelectionHandleController.java | 
| @@ -6,7 +6,7 @@ package org.chromium.content.browser; | 
| import android.view.View; | 
| -class SelectionHandleController { | 
| +abstract class SelectionHandleController { | 
| private View mParent; | 
| @@ -18,4 +18,38 @@ class SelectionHandleController { | 
| public void hideAndDisallowAutomaticShowing() { | 
| // TODO(olilan): add method implementation (this is just a stub for ImeAdapter). | 
| } | 
| + | 
| + /** | 
| + * Moves the start handle so that it points at the given coordinates. | 
| + * @param x | 
| + * @param y | 
| + */ | 
| + public void setStartHandlePosition(int x, int y) { | 
| 
Ted C
2012/09/18 00:21:40
Again, maybe leave out of this change?
 
Ramya
2012/09/21 00:06:29
Done.
 | 
| + // TODO(cramya): add method implementation (this is just a stub). | 
| + } | 
| + | 
| + /** | 
| + * The concrete implementation must trigger a selection between the given | 
| + * coordinates and (possibly asynchronously) set the actual handle positions | 
| + * after the selection is made via showHandlesAt(x1,y1,x2,y2). | 
| + * @param x1 | 
| + * @param y1 | 
| + * @param x2 | 
| + * @param y2 | 
| + */ | 
| + public abstract void selectBetweenCoordinates(int x1, int y1, int x2, int y2); | 
| + | 
| + /** | 
| + * Sets both start and end position and show the handles. | 
| + * Note: this method does not trigger a selection, see | 
| + * selectBetweenCoordinates() | 
| + * | 
| + * @param x1 | 
| + * @param y1 | 
| + * @param x2 | 
| + * @param y2 | 
| + */ | 
| + public void showHandlesAt(int x1, int y1, int dir1, int x2, int y2, int dir2) { | 
| + // TODO(cramya): add method implementation (this is just a stub). | 
| + } | 
| } |