Implement Bookmark Autocomplete Provider

chrome/browser/autocomplete/autocomplete_provider.h

Index: chrome/browser/autocomplete/autocomplete_provider.h
===================================================================
--- chrome/browser/autocomplete/autocomplete_provider.h	(revision 159706)
+++ chrome/browser/autocomplete/autocomplete_provider.h	(working copy)
@@ -50,6 +50,7 @@
 // Search Primary Provider (past query in history older than 2 days)   | 1050--
 // HistoryContents (any match in title of starred page)                | 1000++
 // HistoryURL (some inexact matches)                                   |  900++
+// BookmarkProvider (prefix match in bookmark title)                   |  900+-
 // Search Primary Provider (navigational suggestion)                   |  800++
 // HistoryContents (any match in title of nonstarred page)             |  700++
 // Search Primary Provider (suggestion)                                |  600++
@@ -121,6 +122,7 @@
 // Search Primary Provider (past query in history older than 2 days)   | 1050--
 // HistoryContents (any match in title of starred page)                | 1000++
 // HistoryURL (inexact match)                                          |  900++
+// BookmarkProvider (prefix match in bookmark title)                   |  900+-
 // Search Primary Provider (navigational suggestion)                   |  800++
 // HistoryContents (any match in title of nonstarred page)             |  700++
 // Search Primary Provider (suggestion)                                |  600++
@@ -166,6 +168,8 @@
 // *~: Partial matches get a score on a sliding scale from about 575-1125 based
 //     on how many times the URL for the Extension App has been typed and how
 //     many of the letters match.
+// +-: A base score that the provider will adjust upward or downward based on
+//     provider-specific metrics.
 //
 // A single result provider for the autocomplete system.  Given user input, the
 // provider decides what (if any) matches to return, their relevance, and their
@@ -175,6 +179,7 @@
  public:
   // Different AutocompleteProvider implementations.
   enum Type {
+    TYPE_BOOKMARK         = 1 << 10,

[Mark P, 2012/10/08 22:51:59]

Side comment: alphabetic order without renumbering the values will make it
easier for people to screw something up when adding a new provider later. 
Consider renumbering (if it's allowed).

[Peter Kasting, 2012/10/09 18:30:41]

Agreed, my intent was that these also be renumbered.

[mrossetti, 2012/10/10 02:26:42]

It looks like renumber would be harmless. Done.

On 2012/10/08 22:51:59, Mark P wrote:

     TYPE_BUILTIN          = 1 << 0,
     TYPE_CONTACT          = 1 << 1,
     TYPE_EXTENSION_APP    = 1 << 2,