Implement Bookmark Autocomplete Provider

chrome/browser/autocomplete/autocomplete_provider.cc

Index: chrome/browser/autocomplete/autocomplete_provider.cc
===================================================================
--- chrome/browser/autocomplete/autocomplete_provider.cc	(revision 156377)
+++ chrome/browser/autocomplete/autocomplete_provider.cc	(working copy)
@@ -54,6 +54,8 @@
       return "Shortcuts";
     case TYPE_ZERO_SUGGEST:
       return "ZeroSuggest";
+    case TYPE_BOOKMARK:
+      return "Bookmark";
     default:
       NOTREACHED() << "Unhandled AutocompleteProvider::Type " << type;
       return "Unknown";
@@ -91,6 +93,8 @@
       return metrics::OmniboxEventProto::SHORTCUTS;
     case TYPE_ZERO_SUGGEST:
       // TODO: Add to OmniboxEventProto::ProviderType.

[Mark P, 2012/09/28 00:55:13]

You need to do something here, else ZERO_SUGGEST types will get reutrned as
BOOKMARKS.  (No return on break in section.)

[mrossetti, 2012/10/02 00:44:16]

Done.

+    case TYPE_BOOKMARK:
+      return metrics::OmniboxEventProto::BOOKMARK;
     default:
       NOTREACHED() << "Unhandled AutocompleteProvider::Type " << type_;
       return metrics::OmniboxEventProto::UNKNOWN_PROVIDER;