Implement Bookmark Autocomplete Provider

chrome/common/metrics/proto/omnibox_event.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Stores information about an omnibox interaction.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
@@ skipping 68 matching lines @@
     HISTORY_URL = 1;       // URLs in history, or user-typed URLs
     HISTORY_CONTENTS = 2;  // Matches for page contents of pages in history
     HISTORY_QUICK = 3;     // Matches for recently or frequently visited pages
                            // in history
     SEARCH = 4;            // Search suggestions for the default search engine
     KEYWORD = 5;           // Keyword-triggered searches
     BUILTIN = 6;           // Built-in URLs, such as chrome://version
     SHORTCUTS = 7;         // Recently selected omnibox suggestions
     EXTENSION_APPS = 8;    // Custom suggestions from extensions and/or apps
     CONTACT = 9;           // The user's contacts
+    BOOKMARK = 10;         // The user's bookmarks
   }
 
   // The result set displayed on the completion popup
   // Next tag: 6
   message Suggestion {
     // Where does this result come from?
     optional ProviderType provider = 1;
 
     // What kind of result this is.
     // This corresponds to the AutocompleteMatch::Type enumeration in
     // chrome/browser/autocomplete/autocomplete_match.h
     enum ResultType {
       UNKNOWN_RESULT_TYPE = 0;    // Unknown type (should not reach here)
       URL_WHAT_YOU_TYPED = 1;     // The input as a URL
       HISTORY_URL = 2;            // A past page whose URL contains the input
       HISTORY_TITLE = 3;          // A past page whose title contains the input
       HISTORY_BODY = 4;           // A past page whose body contains the input
       HISTORY_KEYWORD = 5;        // A past page whose keyword contains the
                                   // input
       NAVSUGGEST = 6;             // A suggested URL
       SEARCH_WHAT_YOU_TYPED = 7;  // The input as a search query (with the
                                   // default engine)
       SEARCH_HISTORY = 8;         // A past search (with the default engine)
                                   // containing the input
       SEARCH_SUGGEST = 9;         // A suggested search (with the default
                                   // engine)
       SEARCH_OTHER_ENGINE = 10;   // A search with a non-default engine
       EXTENSION_APP = 11;         // An Extension App with a title/url that
                                   // contains the input
       CONTACT = 12;               // One of the user's contacts

[Mark P, 2012/09/28 00:55:13]

You need to add BOOKMARK_TITLE here too I think.

You also need to modify metrics_service AsOmniboxEventResultType

[mrossetti, 2012/10/02 00:44:16]

Ah! Excellent!

     };
     optional ResultType result_type = 2;
 
     // The relevance score for this suggestion.
     optional int32 relevance = 3;
 
     // How many times this result was typed in / selected from the omnibox.
     // Only set for some providers and result_types.  At the time of
     // writing this comment, it is only set for HistoryURL and
     // HistoryQuickProvider matches.
@@ skipping 12 matching lines @@
 
     // The provider's done() value, i.e., whether it's completed processing
     // the query.  Providers which don't do any asynchronous processing
     // will always be done.
     optional bool provider_done = 2;
   }
   // A list of diagnostic information about each provider.  Providers
   // will appear at most once in this list.
   repeated ProviderInfo provider_info = 12;
 }