extensions: Add ExtensionView interface.

chrome/browser/ui/views/extensions/extension_dialog.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_dialog.h"
 
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/base_window.h"
@@ skipping 85 matching lines @@
   ExtensionDialog* dialog = new ExtensionDialog(host, observer);
   dialog->set_title(title);
 
   if (fullscreen)
     dialog->InitWindowFullscreen();
   else
     dialog->InitWindow(base_window, width, height);
 
   // Show a white background while the extension loads.  This is prettier than
   // flashing a black unfilled window frame.
-  host->view()->set_background(
+  host->GetExtensionView()->set_background(

[tfarina, 2012/09/14 13:36:59]

Aaron, Ben, any idea how I will get the ExtensionViewViews here?

[Aaron Boodman, 2012/09/16 01:07:38]

You can static_cast, I assume. You know that it will be ExtensionViewViews
because this is views-specific code.

       views::Background::CreateSolidBackground(0xFF, 0xFF, 0xFF));
-  host->view()->SetVisible(true);
+  host->GetExtensionView()->SetVisible(true);
 
   // Ensure the DOM JavaScript can respond immediately to keyboard shortcuts.
   host->host_contents()->Focus();
   return dialog;
 }
 
 // static
 extensions::ExtensionHost* ExtensionDialog::CreateExtensionHost(
     const GURL& url,
     Profile* profile) {
@@ skipping 85 matching lines @@
   // See bug.com/127222.
   focus_manager->SetFocusedView(GetContentsView());
   view->Focus();
 }
 
 /////////////////////////////////////////////////////////////////////////////
 // views::WidgetDelegate overrides.
 
 bool ExtensionDialog::CanResize() const {
   // Can resize only if minimum contents size set.
-  return extension_host_->view()->GetPreferredSize() != gfx::Size();
+  return extension_host_->GetExtensionView()->GetPreferredSize() != gfx::Size();
 }
 
 void ExtensionDialog::SetMinimumContentsSize(int width, int height) {
-  extension_host_->view()->SetPreferredSize(gfx::Size(width, height));
+  extension_host_->GetExtensionView()->SetPreferredSize(
+      gfx::Size(width, height));
 }
 
 ui::ModalType ExtensionDialog::GetModalType() const {
   return ui::MODAL_TYPE_WINDOW;
 }
 
 bool ExtensionDialog::ShouldShowWindowTitle() const {
   return !window_title_.empty();
 }
 
 string16 ExtensionDialog::GetWindowTitle() const {
   return window_title_;
 }
 
 void ExtensionDialog::WindowClosing() {
   if (observer_)
     observer_->ExtensionDialogClosing(this);
 }
 
 void ExtensionDialog::DeleteDelegate() {
   // The window has finished closing.  Allow ourself to be deleted.
   Release();
 }
 
 views::Widget* ExtensionDialog::GetWidget() {
-  return extension_host_->view()->GetWidget();
+  return extension_host_->GetExtensionView()->GetWidget();
 }
 
 const views::Widget* ExtensionDialog::GetWidget() const {
-  return extension_host_->view()->GetWidget();
+  return extension_host_->GetExtensionView()->GetWidget();
 }
 
 views::View* ExtensionDialog::GetContentsView() {
-  return extension_host_->view();
+  return extension_host_->GetExtensionView();
 }
 
 /////////////////////////////////////////////////////////////////////////////
 // content::NotificationObserver overrides.
 
 void ExtensionDialog::Observe(int type,
                              const content::NotificationSource& source,
                              const content::NotificationDetails& details) {
   switch (type) {
     case chrome::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING:
       // Avoid potential overdraw by removing the temporary background after
       // the extension finishes loading.
-      extension_host_->view()->set_background(NULL);
+      extension_host_->GetExtensionView()->set_background(NULL);
       // The render view is created during the LoadURL(), so we should
       // set the focus to the view if nobody else takes the focus.
       if (content::Details<extensions::ExtensionHost>(host()) == details)
         MaybeFocusRenderView();
       break;
     case chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE:
       // If we aren't the host of the popup, then disregard the notification.
       if (content::Details<extensions::ExtensionHost>(host()) != details)
         return;
       Close();
       break;
     case chrome::NOTIFICATION_EXTENSION_PROCESS_TERMINATED:
       if (content::Details<extensions::ExtensionHost>(host()) != details)
         return;
       if (observer_)
         observer_->ExtensionTerminated(this);
       break;
     default:
       NOTREACHED() << L"Received unexpected notification";
       break;
   }
 }