Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 10913218: Ignore "range" parameter in Android FlingAnimator (Closed)

Created:
8 years, 3 months ago by Iain Merrick
Modified:
8 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Ignore "range" parameter in Android FlingAnimator WebKit is passing an empty range, which means flings are always immediately halted on Android. This patch ignores the parameter and just uses INT_MIN / INT_MAX for the range. This fixes fling gestures in the Android content shell. Also simplified code by calling an overloaded Java method with fewer parameters (we were just passing 0 for the extra "overfling range" parameters, and they have no effect anyway unless we hit the max scrolling range, which this patch prevents). Other platforms don't need this parameter so we'll probably just remove it from the WebKit API. See discussion on WebKit bug: http://webkit.org/b/96403 BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M webkit/glue/fling_animator_impl_android.cc View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Iain Merrick
8 years, 3 months ago (2012-09-12 10:52:56 UTC) #1
Iain Merrick
8 years, 3 months ago (2012-09-12 16:26:00 UTC) #2
jamesr
This is fine for now, but it looks like you really do need the actual ...
8 years, 3 months ago (2012-09-12 18:25:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/husky@chromium.org/10913218/1
8 years, 3 months ago (2012-09-12 19:41:00 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-12 23:23:35 UTC) #5
Change committed as 156416

Powered by Google App Engine
This is Rietveld 408576698