Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3289)

Unified Diff: chrome/browser/chrome_to_mobile_service.h

Issue 10913089: Adjust ChromeToMobile error logging and mitigation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comment. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_to_mobile_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_to_mobile_service.h
diff --git a/chrome/browser/chrome_to_mobile_service.h b/chrome/browser/chrome_to_mobile_service.h
index 162180d7b5b0dd72d118245c8edfe56aadc1acf1..78129701f94e9258f65dc14120479972c7ca528d 100644
--- a/chrome/browser/chrome_to_mobile_service.h
+++ b/chrome/browser/chrome_to_mobile_service.h
@@ -67,6 +67,14 @@ class ChromeToMobileService : public ProfileKeyedService,
SEND_SUCCESS, // Cloud print responded with success on send.
SEND_ERROR, // Cloud print responded with failure on send.
LEARN_MORE_CLICKED, // The "Learn more" help article link was clicked.
+ BAD_TOKEN, // The cloud print access token could not be minted.
+ BAD_SEARCH_AUTH, // The cloud print search request failed (auth).
+ BAD_SEARCH_OTHER, // The cloud print search request failed (other).
+ BAD_SEND_407, // The cloud print send response was errorCode==407.
+ // "Print job added but failed to notify printer..."
+ BAD_SEND_ERROR, // The cloud print send response was errorCode!=407.
+ BAD_SEND_AUTH, // The cloud print send request failed (auth).
+ BAD_SEND_OTHER, // The cloud print send request failed (other).
NUM_METRICS
};
@@ -223,9 +231,10 @@ class ChromeToMobileService : public ProfileKeyedService,
RequestObserverMap;
RequestObserverMap request_observer_map_;
- // The pending OAuth access token request and a timer for retrying on failure.
+ // The pending OAuth access token request and timers for retrying on failure.
scoped_ptr<OAuth2AccessTokenFetcher> access_token_fetcher_;
base::OneShotTimer<ChromeToMobileService> auth_retry_timer_;
+ base::OneShotTimer<ChromeToMobileService> search_retry_timer_;
// A queue of tasks to perform after an access token is lazily initialized.
std::queue<base::Closure> task_queue_;
« no previous file with comments | « no previous file | chrome/browser/chrome_to_mobile_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698