Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2654)

Unified Diff: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

Issue 10912183: Remove DownloadManager::GetDownloadItem in favor of GetDownload() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/chrome_download_manager_delegate_unittest.cc
diff --git a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
index 054969d65220e38e4f803999557d2a176184ca53..8fc10a8421989129dc5f2307336e427d22361f91 100644
--- a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
@@ -293,6 +293,8 @@ ChromeDownloadManagerDelegateTest::ChromeDownloadManagerDelegateTest()
ui_thread_(content::BrowserThread::UI, &message_loop_),
file_thread_(content::BrowserThread::FILE, &message_loop_),
download_manager_(new content::MockDownloadManager) {
+ EXPECT_CALL(*download_manager_, AddObserver(_)).WillRepeatedly(Return());
+ EXPECT_CALL(*download_manager_, RemoveObserver(_)).WillRepeatedly(Return());
}
void ChromeDownloadManagerDelegateTest::SetUp() {
@@ -317,6 +319,7 @@ void ChromeDownloadManagerDelegateTest::TearDown() {
void ChromeDownloadManagerDelegateTest::VerifyAndClearExpectations() {
::testing::Mock::VerifyAndClearExpectations(delegate_);
::testing::Mock::VerifyAndClearExpectations(download_manager_);
+ EXPECT_CALL(*download_manager_, RemoveObserver(_)).WillRepeatedly(Return());
}
content::MockDownloadItem*
@@ -341,7 +344,9 @@ content::MockDownloadItem*
.WillByDefault(Return(contents()));
EXPECT_CALL(*item, GetId())
.WillRepeatedly(Return(id));
- EXPECT_CALL(*download_manager_, GetActiveDownloadItem(id))
+ EXPECT_CALL(*item, AddObserver(_)).WillRepeatedly(Return());
+ EXPECT_CALL(*item, RemoveObserver(_)).WillRepeatedly(Return());
+ EXPECT_CALL(*download_manager_, GetDownload(id))
.WillRepeatedly(Return(item));
return item;
}

Powered by Google App Engine
This is Rietveld 408576698