Remove DownloadManager::GetDownloadItem in favor of GetDownload()

chrome/browser/ui/webui/downloads_dom_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/downloads_dom_handler.h"
 
 #include <algorithm>
 #include <functional>
 
 #include "base/basictypes.h"
@@ skipping 482 matching lines @@
       dangerous_item,
       TabContents::FromWebContents(GetWebUIWebContents()),
       base::Bind(&DownloadsDOMHandler::DangerPromptAccepted,
                  weak_ptr_factory_.GetWeakPtr(), dangerous_item->GetId()),
       base::Closure());
   // danger_prompt will delete itself.
   DCHECK(danger_prompt);
 }
 
 void DownloadsDOMHandler::DangerPromptAccepted(int download_id) {
-  content::DownloadItem* item = download_manager_->GetActiveDownloadItem(
-      download_id);
+  content::DownloadItem* item = download_manager_->GetDownload(download_id);

[Randy Smith (Not in Mondays), 2012/09/11 19:02:21]

I think we want a cancellation/interrupt guard somewhere along this pathway.  I
don't care if it's here or in DangerousDownloadValidated().

[benjhayden, 2012/09/12 18:17:25]

Done.

   if (!item)
     return;
   CountDownloadsDOMEvents(DOWNLOADS_DOM_EVENT_SAVE_DANGEROUS);
   item->DangerousDownloadValidated();
 }
 
 content::DownloadItem* DownloadsDOMHandler::GetDownloadByValue(
     const base::ListValue* args) {
   int id = -1;
   if (!ExtractIntegerValue(args, &id))
     return NULL;
   content::DownloadItem* download_item = download_manager_->GetDownload(id);
   if (!download_item && original_profile_download_manager_)
     download_item = original_profile_download_manager_->GetDownload(id);
   return download_item;
 }
 
 content::WebContents* DownloadsDOMHandler::GetWebUIWebContents() {
   return web_ui()->GetWebContents();
 }
 
 void DownloadsDOMHandler::CallDownloadsList(const base::ListValue& downloads) {
   web_ui()->CallJavascriptFunction("downloadsList", downloads);
 }
 
 void DownloadsDOMHandler::CallDownloadUpdated(
     const base::ListValue& download_item) {
   web_ui()->CallJavascriptFunction("downloadUpdated", download_item);
 }