Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: content/browser/download/download_file_factory.h

Issue 10912173: Replace the DownloadFileManager with direct ownership of DownloadFileImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments and sync'd to r158560 Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_factory.h
diff --git a/content/browser/download/download_file_factory.h b/content/browser/download/download_file_factory.h
index f1f8478ce4899d9db1de233c6f69a1971dc09295..c4d8a4f574338208244fd81bea485def4b9764d9 100644
--- a/content/browser/download/download_file_factory.h
+++ b/content/browser/download/download_file_factory.h
@@ -5,11 +5,11 @@
#ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_FACTORY_H_
#define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_FACTORY_H_
+#include "base/file_path.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "content/common/content_export.h"
-#include "content/browser/download/download_create_info.h"
#include "googleurl/src/gurl.h"
namespace net {
@@ -30,11 +30,15 @@ class CONTENT_EXPORT DownloadFileFactory {
virtual ~DownloadFileFactory();
virtual content::DownloadFile* CreateFile(
- DownloadCreateInfo* info,
- scoped_ptr<content::ByteStreamReader> stream,
- DownloadManager* download_manager,
- bool calculate_hash,
- const net::BoundNetLog& bound_net_log);
+ const content::DownloadSaveInfo& save_info,
asanka 2012/09/28 20:22:42 Here's that extra content:: namespace again :)
Randy Smith (Not in Mondays) 2012/10/09 20:20:19 Indeed. Just when you think you've gotten rid of
+ const FilePath& default_downloads_directory,
+ GURL url,
+ GURL referrer_url,
+ int64 received_bytes,
+ bool calculate_hash,
+ scoped_ptr<content::ByteStreamReader> stream,
+ const net::BoundNetLog& bound_net_log,
+ base::WeakPtr<content::DownloadDestinationObserver> observer);
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698