content/browser/download/download_create_info.h - Issue 10912173: Replace the DownloadFileManager with direct ownership of DownloadFileImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_create_info.h

Issue 10912173: Replace the DownloadFileManager with direct ownership of DownloadFileImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated comments and sync'd to r158560 Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/download/download_browsertest.cc ('k') | content/browser/download/download_file.h » ('j') | content/browser/download/download_file_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_create_info.h

diff --git a/content/browser/download/download_create_info.h b/content/browser/download/download_create_info.h

index 4e0cc3f6fce5fa96077179fc80454b67370986fa..9c5e11f5e3aae88d106c723fa657ea7e11ae2a57 100644

--- a/content/browser/download/download_create_info.h

+++ b/content/browser/download/download_create_info.h

@@ -107,13 +107,6 @@ struct CONTENT_EXPORT DownloadCreateInfo {

// The handle to the URLRequest sourcing this download.

DownloadRequestHandle request_handle;

- // Default directory to use for this download. The final target path may not

- // be determined until much later. In the meantime, this directory (if

- // non-empty) should be used to store teh download file.

- // TODO(asanka,rdsmith): Get rid of this when we start creating the

- // DownloadFile on the UI thread.

- FilePath default_download_directory;

// The request's |BoundNetLog|, for "source_dependency" linking with the

// download item's.

const net::BoundNetLog request_bound_net_log;