content/browser/browser_main_loop.cc - Issue 10912173: Replace the DownloadFileManager with direct ownership of DownloadFileImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_main_loop.cc

Issue 10912173: Replace the DownloadFileManager with direct ownership of DownloadFileImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated comments and sync'd to r158560 Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/browser_main_loop.cc

diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc

index 1a4153e6bd431ea18682176a494bf287e6cf8e13..d55567a8404974bd7109ab6d1af39d2f0529cfce 100644

--- a/content/browser/browser_main_loop.cc

+++ b/content/browser/browser_main_loop.cc

@@ -16,7 +16,6 @@

#include "base/string_number_conversions.h"

#include "base/threading/thread_restrictions.h"

#include "content/browser/browser_thread_impl.h"

-#include "content/browser/download/download_file_manager.h"

#include "content/browser/download/save_file_manager.h"

#include "content/browser/gamepad/gamepad_service.h"

#include "content/browser/gpu/browser_gpu_channel_host_factory.h"

@@ -575,10 +574,8 @@ void BrowserMainLoop::ShutdownThreadsAndCleanUp() {

#if !defined(OS_IOS)

// Clean up state that lives on or uses the file_thread_ before

// it goes away.

- if (resource_dispatcher_host_.get()) {

- resource_dispatcher_host_.get()->download_file_manager()->Shutdown();

+ if (resource_dispatcher_host_.get())

resource_dispatcher_host_.get()->save_file_manager()->Shutdown();

- }

#endif // !defined(OS_IOS)

break;

case BrowserThread::PROCESS_LAUNCHER:

« no previous file with comments | « content/browser/browser_context.cc ('k') | content/browser/download/base_file.h » ('j') | content/browser/download/download_file_factory.h » ('J')