Replace the DownloadFileManager with direct ownership of DownloadFileImpl

content/browser/download/download_item_impl_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/logging.h"
 #include "content/browser/download/download_item_impl_delegate.h"
 
-class DownloadItemImpl;
+#include "base/logging.h"
+#include "content/browser/download/download_item_impl.h"
 
 // Infrastructure in DownloadItemImplDelegate to assert invariant that
 // delegate always outlives all attached DownloadItemImpls.
 DownloadItemImplDelegate::DownloadItemImplDelegate()
     : count_(0) {}
 
 DownloadItemImplDelegate::~DownloadItemImplDelegate() {
   DCHECK_EQ(0, count_);
 }
 
 void DownloadItemImplDelegate::Attach() {
   ++count_;
 }
 
 void DownloadItemImplDelegate::Detach() {
   DCHECK_LT(0, count_);
   --count_;
 }
 
+void DownloadItemImplDelegate::DetermineDownloadTarget(
+    DownloadItemImpl* download, DownloadTargetCallback callback) {

[asanka, 2012/09/28 20:22:42]

Why is this a concrete class?

[Randy Smith (Not in Mondays), 2012/10/09 20:20:19]

As per offline conversation: The chrome/content delegate pattern is now to have
default implementations to make creating an embedder as easy as possible.  I'm
following that pattern here even thought this isn't a chrome/content class.

Having said that, I'm not sure this is the right thing to do--there's a
noticeable win in making these kind of classes ABCs in that you find out PDQ
(:-}) when you mock them if you've overridden all the methods or not.  I'm not
going to make the change in this CL, but I'll think about doing it in a separate
CL.

+  // TODO(rdsmith/asanka): Do something useful if forced file path is null.
+  FilePath target_path(download->GetForcedFilePath());
+  callback.Run(target_path,
+               content::DownloadItem::TARGET_DISPOSITION_OVERWRITE,
+               content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
+               target_path);
+}
+
+bool DownloadItemImplDelegate::ShouldOpenDownload(DownloadItemImpl* download) {
+  return false;
+}
+
 bool DownloadItemImplDelegate::ShouldOpenFileBasedOnExtension(
     const FilePath& path) {
   return false;
 }
 
-bool DownloadItemImplDelegate::ShouldOpenDownload(DownloadItemImpl* download) {
-  return false;
-}
-
 void DownloadItemImplDelegate::CheckForFileRemoval(
     DownloadItemImpl* download_item) {}
 
 void DownloadItemImplDelegate::MaybeCompleteDownload(
     DownloadItemImpl* download) {}
 
 content::BrowserContext* DownloadItemImplDelegate::GetBrowserContext() const {
   return NULL;
 }
 
@@ skipping 10 matching lines @@
 void DownloadItemImplDelegate::DownloadRemoved(DownloadItemImpl* download) {}
 
 void DownloadItemImplDelegate::DownloadRenamedToIntermediateName(
     DownloadItemImpl* download) {}
 
 void DownloadItemImplDelegate::DownloadRenamedToFinalName(
     DownloadItemImpl* download) {}
 
 void DownloadItemImplDelegate::AssertStateConsistent(
     DownloadItemImpl* download) const {}