Replace the DownloadFileManager with direct ownership of DownloadFileImpl

content/browser/download/download_file.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/file_path.h"
 #include "content/common/content_export.h"
-#include "content/public/browser/download_id.h"
 #include "content/public/browser/download_interrupt_reasons.h"
 
 namespace content {
 
 class DownloadManager;
 
 // These objects live exclusively on the file thread and handle the writing
 // operations for one download. These objects live only for the duration that
 // the download is 'in progress': once the download has been completed or
 // cancelled, the DownloadFile is destroyed.
 class CONTENT_EXPORT DownloadFile {
  public:
+  // Callback used with Initialize.  On a successful initialize, |reason| will
+  // be DOWNLOAD_INTERRUPT_REASON_NONE; on a failed initialize, it will be
+  // set to the reason for the failure.
+  typedef base::Callback<void(content::DownloadInterruptReason reason)>
+      InitializeCallback;
+
   // Callback used with Rename().  On a successful rename |reason| will be
   // DOWNLOAD_INTERRUPT_REASON_NONE and |path| the path the rename
   // was done to.  On a failed rename, |reason| will contain the
   // error.
   typedef base::Callback<void(DownloadInterruptReason reason,
                               const FilePath& path)> RenameCompletionCallback;
 
   virtual ~DownloadFile() {}
 
   // Returns DOWNLOAD_INTERRUPT_REASON_NONE on success, or a network
   // error code on failure.  Upon completion, |callback| will be
   // called on the UI thread as per the comment above.
-  virtual content::DownloadInterruptReason Initialize() = 0;
+  virtual void Initialize(const InitializeCallback& callback) = 0;
 
   // Rename the download file to |full_path|.  If that file exists and
   // |overwrite_existing_file| is false, |full_path| will be uniquified by
   // suffixing " (<number>)" to the file name before the extension.
   // Upon completion, |callback| will be called on the UI thread
   // as per the comment above.
   virtual void Rename(const FilePath& full_path,
                       bool overwrite_existing_file,
                       const RenameCompletionCallback& callback) = 0;
 
@@ skipping 12 matching lines @@
   virtual int64 BytesSoFar() const = 0;
   virtual int64 CurrentSpeed() const = 0;
 
   // Set |hash| with sha256 digest for the file.
   // Returns true if digest is successfully calculated.
   virtual bool GetHash(std::string* hash) = 0;
 
   // Returns the current (intermediate) state of the hash as a byte string.
   virtual std::string GetHashState() = 0;
 
-  // Cancels the download request associated with this file.
-  virtual void CancelDownloadRequest() = 0;
+  // For testing.  Must be called on FILE thread.
+  // TODO(rdsmith): Remove use of EnsureNoPendingDownloads()
+  // on the DownloadManager is replaced by a test-specific DownloadFileFactory

[benjhayden, 2012/09/24 17:43:27]

Grammar check

[Randy Smith (Not in Mondays), 2012/09/26 21:01:05]

Done.

+  // which keeps track of the number of DownloadFiles.
+  static int GetNumberOfDownloadFiles();
 
-  virtual int Id() const = 0;
-  virtual DownloadManager* GetDownloadManager() = 0;
-  virtual const DownloadId& GlobalId() const = 0;
-
-  virtual std::string DebugString() const = 0;
+ protected:
+  static int number_active_objects_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_