Build NetError.java to use in java side tests by preprocessing net_errors.cc

net/net.gyp

Index: net/net.gyp
diff --git a/net/net.gyp b/net/net.gyp
index 448045cdbcfc45b6d0b1cd53863adbcdfb677edd..bbb8f9acdc8a28a33c6c0b390f8a66f6efcb5a44 100644
--- a/net/net.gyp
+++ b/net/net.gyp
@@ -2073,6 +2073,7 @@
           },
           'dependencies': [
             '../base/base.gyp:base_java',
+            'net_errors_java',

[Yaron, 2012/09/07 01:05:44]

This should be added to export_dependent_settings 

           ],
           'export_dependent_settings': [
             '../base/base.gyp:base_java',
@@ -2089,6 +2090,7 @@
           'dependencies': [
             '../base/base.gyp:base_java',
             '../base/base.gyp:base_java_test_support',
+            'net_errors_java',

[Yaron, 2012/09/07 01:05:44]

This should be pulled transitively through net_java.

           ],
           'export_dependent_settings': [
             '../base/base.gyp:base_java',
@@ -2096,6 +2098,37 @@
           ],
           'includes': [ '../build/java.gypi' ],
         },
+        {
+          'target_name': 'net_errors_java',

[Yaron, 2012/09/07 01:05:44]

This should use a new gyp template (like build/java.gypi) and parameterized
accordingly because presumably will be used elsewhere

[joth, 2012/09/07 21:45:46]

right now net_error_list.h is the only known example of this style of constant
list. I agree we're likely to want to add more in future, but I'd just put a
comment here indicating this should be extracted as gypi if/when another user
for it is needed.
(at the same point we may want to remove the checked in .template file and have
a  more cleverer script generate that guy on the fly too, before running the
pre-processor over it)

+          'type': 'none',
+          'direct_dependent_settings': {
+            'variables': {
+              'additional_src_dirs': ['<(SHARED_INTERMEDIATE_DIR)/net/template/'],
+            },
+          },
+          'actions': [
+            {
+              'action_name': 'generate_net_errors_java',
+              'inputs': [
+                'android/java/net_errors_java.template',
+              ],
+              'outputs': [
+                '<(SHARED_INTERMEDIATE_DIR)/net/template/NetError.java',

[Yaron, 2012/09/07 01:05:44]

I don't see where this java file gets compiled or included in the jar/apk?

[joth, 2012/09/07 21:45:46]

the 'additional_src_dirs' statement above shoves this into any dependent code's
build

[Yaron, 2012/09/07 22:49:06]

Right, thanks!

+              ],
+              'action': [
+                'gcc',
+                '-x', 'c-header',
+                '-E', '-P',
+                '-I', '..',
+                '-o',
+                '<@(_outputs)',
+                '<@(_inputs)',
+              ],
+              'message': 'Preprocessing <(_inputs)',
+              'process_outputs_as_sources': 1,
+            },
+          ],
+        },
       ],
     }],
     # Special target to wrap a gtest_target_type==shared_library