Move ProxyConfigService construction onto the IO thread.

chrome/browser/profiles/profile_io_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 188 matching lines @@
     DesktopNotificationService* notification_service;
 #endif
 
     // This pointer exists only as a means of conveying a url interceptor
     // pointer from the protocol handler registry on the UI thread to the
     // the URLRequestJobFactory on the IO thread. The consumer MUST take
     // ownership of the object by calling release() on this pointer.
     scoped_ptr<net::URLRequestJobFactory::Interceptor>
         protocol_handler_interceptor;
 
-    // We need to initialize the ProxyConfigService from the UI thread
-    // because on linux it relies on initializing things through gconf,
-    // and needs to be on the main thread.
-    scoped_ptr<net::ProxyConfigService> proxy_config_service;
+    // Used on the UI thread to return a pointer to the Profile.

[willchan no longer on Chromium, 2012/10/19 18:06:36]

This is too powerful. We should try to keep the scope narrow. The Profile object
contains too many dependencies. Please restructure the callback so it doesn't
return a raw Profile*, but only exactly what you need.

I am still looking, but you should make sure to handle shutdown properly. What
happens when this gets posted from the IO thread to the UI thread while the
profile (let's say an incognito profile) is being destroyed? Do we get a use
after free? Be very very careful :)

[pauljensen, 2012/10/19 22:34:28]

Sorry, I was just copying how ChromeCookieMonsterDelegate gets a pointer to the
Profile.  I could instead replace it with a Callback that just takes a
ChromeProxyConfigService argument and doesn't return anything.
It uses GetProfileOnUI() which checks with IsValidProfile() to make sure its
still alive.

+    base::Callback<Profile*(void)> profile_getter;
     // The profile this struct was populated from. It's passed as a void* to
     // ensure it's not accidently used on the IO thread. Before using it on the
     // UI thread, call ProfileManager::IsValidProfile to ensure it's alive.
     void* profile;
   };
 
   explicit ProfileIOData(bool is_incognito);
 
   static std::string GetSSLSessionCacheShard();
 
@@ skipping 206 matching lines @@
 
   // TODO(jhawkins): Remove once crbug.com/102004 is fixed.
   bool initialized_on_UI_thread_;
 
   bool is_incognito_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileIOData);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_