Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/browser/net/pref_proxy_config_tracker_impl.h

Issue 10912132: Move ProxyConfigService construction onto the IO thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extra blank line Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_PREF_PROXY_CONFIG_TRACKER_IMPL_H_ 5 #ifndef CHROME_BROWSER_NET_PREF_PROXY_CONFIG_TRACKER_IMPL_H_
6 #define CHROME_BROWSER_NET_PREF_PROXY_CONFIG_TRACKER_IMPL_H_ 6 #define CHROME_BROWSER_NET_PREF_PROXY_CONFIG_TRACKER_IMPL_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 23 matching lines...) Expand all
34 virtual ~ChromeProxyConfigService(); 34 virtual ~ChromeProxyConfigService();
35 35
36 // ProxyConfigService implementation: 36 // ProxyConfigService implementation:
37 virtual void AddObserver( 37 virtual void AddObserver(
38 net::ProxyConfigService::Observer* observer) OVERRIDE; 38 net::ProxyConfigService::Observer* observer) OVERRIDE;
39 virtual void RemoveObserver( 39 virtual void RemoveObserver(
40 net::ProxyConfigService::Observer* observer) OVERRIDE; 40 net::ProxyConfigService::Observer* observer) OVERRIDE;
41 virtual ConfigAvailability GetLatestProxyConfig( 41 virtual ConfigAvailability GetLatestProxyConfig(
42 net::ProxyConfig* config) OVERRIDE; 42 net::ProxyConfig* config) OVERRIDE;
43 virtual void OnLazyPoll() OVERRIDE; 43 virtual void OnLazyPoll() OVERRIDE;
44 virtual void StartTearDown() OVERRIDE;
44 45
45 // Method on IO thread that receives the preference proxy settings pushed from 46 // Method on IO thread that receives the preference proxy settings pushed from
46 // PrefProxyConfigTrackerImpl. 47 // PrefProxyConfigTrackerImpl.
47 void UpdateProxyConfig(ProxyPrefs::ConfigState config_state, 48 void UpdateProxyConfig(ProxyPrefs::ConfigState config_state,
48 const net::ProxyConfig& config); 49 const net::ProxyConfig& config);
49 50
50 private: 51 private:
51 // ProxyConfigService::Observer implementation: 52 // ProxyConfigService::Observer implementation:
52 virtual void OnProxyConfigChanged(const net::ProxyConfig& config, 53 virtual void OnProxyConfigChanged(const net::ProxyConfig& config,
53 ConfigAvailability availability) OVERRIDE; 54 ConfigAvailability availability) OVERRIDE;
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 157
157 PrefService* pref_service_; 158 PrefService* pref_service_;
158 ChromeProxyConfigService* chrome_proxy_config_service_; // Weak ptr. 159 ChromeProxyConfigService* chrome_proxy_config_service_; // Weak ptr.
159 bool update_pending_; // True if config has not been pushed to network stack. 160 bool update_pending_; // True if config has not been pushed to network stack.
160 scoped_ptr<PrefSetObserver> proxy_prefs_observer_; 161 scoped_ptr<PrefSetObserver> proxy_prefs_observer_;
161 162
162 DISALLOW_COPY_AND_ASSIGN(PrefProxyConfigTrackerImpl); 163 DISALLOW_COPY_AND_ASSIGN(PrefProxyConfigTrackerImpl);
163 }; 164 };
164 165
165 #endif // CHROME_BROWSER_NET_PREF_PROXY_CONFIG_TRACKER_IMPL_H_ 166 #endif // CHROME_BROWSER_NET_PREF_PROXY_CONFIG_TRACKER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698