Move ProxyConfigService construction onto the IO thread.

chrome/browser/io_thread.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IO_THREAD_H_
 #define CHROME_BROWSER_IO_THREAD_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/api/prefs/pref_member.h"
 #include "chrome/browser/net/ssl_config_service_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/browser_thread_delegate.h"
 #include "net/base/network_change_notifier.h"
 
 class ChromeNetLog;
+class ChromeProxyConfigService;
 class PrefProxyConfigTrackerImpl;
 class PrefService;
 class SystemURLRequestContextGetter;
 
 namespace chrome_browser_net {
 class HttpPipeliningCompatibilityClient;
 class LoadTimeStats;
 }
 
 namespace extensions {
 class EventRouterForwarder;
 }
 
 namespace net {
 class CertVerifier;
 class CookieStore;
 class FtpTransactionFactory;
 class HostMappingRules;
 class HostResolver;
 class HttpAuthHandlerFactory;
 class HttpServerProperties;
 class HttpTransactionFactory;
 class NetworkDelegate;
 class ServerBoundCertService;
-class ProxyConfigService;
 class ProxyService;
 class SdchManager;
 class SSLConfigService;
 class TransportSecurityState;
 class URLRequestContext;
 class URLRequestContextGetter;
 class URLRequestThrottlerManager;
 class URLSecurityManager;
 }  // namespace net
 
@@ skipping 80 matching lines @@
   void ChangedToOnTheRecord();
 
   // Returns a getter for the URLRequestContext.  Only called on the UI thread.
   net::URLRequestContextGetter* system_url_request_context_getter();
 
   // Clears the host cache.  Intended to be used to prevent exposing recently
   // visited sites on about:net-internals/#dns and about:dns pages.  Must be
   // called on the IO thread.
   void ClearHostCache();
 
+  // Called on the UI thread to indicate now is the time for shutdown work that

[willchan no longer on Chromium, 2012/10/19 18:06:36]

Can you explain why this hook needs to exist? Why can't you use
IOThread::~IOThread()?

Note that the IOThread *object* lives on the UI thread.

[pauljensen, 2012/10/19 22:34:28]

~IOThread() is called after every thread except the UI thread is gone which is
too late to stop notifications for SettingGetterImplKDE which arrive on the file
thread.

+  // must occur on the UI thread.  Its also one of the last safe times to post
+  // shutdown tasks to other browser threads.
+  void StartTearDown();
+
  private:
   // BrowserThreadDelegate implementation, runs on the IO thread.
   // This handles initialization and destruction of state that must
   // live on the IO thread.
   virtual void Init() OVERRIDE;
   virtual void CleanUp() OVERRIDE;
 
   // Provide SystemURLRequestContextGetter with access to
   // InitSystemRequestContext().
   friend class SystemURLRequestContextGetter;
@@ skipping 48 matching lines @@
   bool negotiate_enable_port_;
   std::string auth_server_whitelist_;
   std::string auth_delegate_whitelist_;
   std::string gssapi_library_name_;
   std::string spdyproxy_origin_;
 
   // This is an instance of the default SSLConfigServiceManager for the current
   // platform and it gets SSL preferences from local_state object.
   scoped_ptr<SSLConfigServiceManager> ssl_config_service_manager_;
 
-  // These member variables are initialized by a task posted to the IO thread,
-  // which gets posted by calling certain member functions of IOThread.
-  scoped_ptr<net::ProxyConfigService> system_proxy_config_service_;
+  scoped_ptr<ChromeProxyConfigService> system_proxy_config_service_;
 
   scoped_ptr<PrefProxyConfigTrackerImpl> pref_proxy_config_tracker_;
 
+  // This member variable is initialized by a task posted to the IO thread,
+  // which gets posted by calling certain member functions of IOThread.
   scoped_refptr<net::URLRequestContextGetter>
       system_url_request_context_getter_;
 
   net::SdchManager* sdch_manager_;
 
   base::WeakPtrFactory<IOThread> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(IOThread);
 };
 
 #endif  // CHROME_BROWSER_IO_THREAD_H_