Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 10912096: C++ reability review for gab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix up last backward if else block found with regex('if \(.* != .*\) \{(\n[^}]*)*\} else') Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index a73a7f686f6e4125a6dd3cb4b04ba4bab559eb05..f8092604c8f71c98d9b1e03506d5e77b9cfbb89a 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -4,6 +4,8 @@
//
// This file defines the methods useful for uninstalling Chrome.
+//Pickup file for readability review.
+
#include "chrome/installer/setup/uninstall.h"
#include <windows.h>
@@ -132,7 +134,7 @@ void ProcessOnOsUpgradeWorkItems(
const installer::Product& product) {
scoped_ptr<WorkItemList> work_item_list(
WorkItem::CreateNoRollbackWorkItemList());
- AddOsUpgradeWorkItems(installer_state, NULL, NULL, product,
+ AddOsUpgradeWorkItems(installer_state, FilePath(), Version(), product,
work_item_list.get());
if (!work_item_list->Do())
LOG(ERROR) << "Failed to remove on-os-upgrade command.";
@@ -146,11 +148,12 @@ void ProcessQuickEnableWorkItems(
scoped_ptr<WorkItemList> work_item_list(
WorkItem::CreateNoRollbackWorkItemList());
- AddQuickEnableChromeFrameWorkItems(installer_state, machine_state, NULL, NULL,
- work_item_list.get());
+ AddQuickEnableChromeFrameWorkItems(installer_state, machine_state, FilePath(),
+ Version(), work_item_list.get());
- AddQuickEnableApplicationHostWorkItems(installer_state, machine_state, NULL,
- NULL, work_item_list.get());
+ AddQuickEnableApplicationHostWorkItems(installer_state, machine_state,
+ FilePath(), Version(),
+ work_item_list.get());
if (!work_item_list->Do())
LOG(ERROR) << "Failed to update quick-enable-cf command.";
}
@@ -283,18 +286,21 @@ void DeleteChromeShortcuts(const InstallerState& installer_state,
ShellUtil::SHORTCUT_ALTERNATE);
}
- ShellUtil::RemoveChromeQuickLaunchShortcut(product.distribution(),
+ ShellUtil::RemoveChromeQuickLaunchShortcut(
+ product.distribution(),
ShellUtil::CURRENT_USER | ShellUtil::SYSTEM_LEVEL);
} else {
PathService::Get(base::DIR_START_MENU, &shortcut_path);
- if (!ShellUtil::RemoveChromeDesktopShortcut(product.distribution(),
+ if (!ShellUtil::RemoveChromeDesktopShortcut(
+ product.distribution(),
ShellUtil::CURRENT_USER, ShellUtil::SHORTCUT_NO_OPTIONS)) {
- ShellUtil::RemoveChromeDesktopShortcut(product.distribution(),
+ ShellUtil::RemoveChromeDesktopShortcut(
+ product.distribution(),
ShellUtil::CURRENT_USER, ShellUtil::SHORTCUT_ALTERNATE);
}
- ShellUtil::RemoveChromeQuickLaunchShortcut(product.distribution(),
- ShellUtil::CURRENT_USER);
+ ShellUtil::RemoveChromeQuickLaunchShortcut(
+ product.distribution(), ShellUtil::CURRENT_USER);
}
if (shortcut_path.empty()) {
LOG(ERROR) << "Failed to get location for shortcut.";
@@ -677,7 +683,8 @@ bool DeleteChromeRegistrationKeys(BrowserDistribution* dist, HKEY root,
}
// Delete Software\RegisteredApplications\Chromium
- InstallUtil::DeleteRegistryValue(root, ShellUtil::kRegRegisteredApplications,
+ InstallUtil::DeleteRegistryValue(
+ root, ShellUtil::kRegRegisteredApplications,
dist->GetBaseAppName() + browser_entry_suffix);
// Delete the App Paths and Applications keys that let Explorer find Chrome:

Powered by Google App Engine
This is Rietveld 408576698