chrome/installer/util/util_constants.h - Issue 10912096: C++ reability review for gab.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/util/util_constants.h

Issue 10912096: C++ reability review for gab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/installer/setup/setup_util.cc ('K') | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/util_constants.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Defines all install related constants that need to be used by Chrome as	5 // Defines all install related constants that need to be used by Chrome as

6 // well as Chrome Installer.	6 // well as Chrome Installer.

7	7

	8 //Pickup file for readability review.

	9

8 #ifndef CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_	10 #ifndef CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_

9 #define CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_	11 #define CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_

10	12

11 #include "base/basictypes.h"	13 #include "base/basictypes.h"

12	14

13 namespace installer {	15 namespace installer {

14	16

15 // Return status of installer	17 // Return status of installer

16 enum InstallStatus {	18 enum InstallStatus {

17 FIRST_INSTALL_SUCCESS, // 0. Successfully installed Chrome for the first time	19 FIRST_INSTALL_SUCCESS, // 0. Successfully installed Chrome for the first time

(...skipping 203 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
221 extern const wchar_t kChromeChannelCanary[];	223 extern const wchar_t kChromeChannelCanary[];

222 extern const wchar_t kChromeChannelDev[];	224 extern const wchar_t kChromeChannelDev[];

223 extern const wchar_t kChromeChannelBeta[];	225 extern const wchar_t kChromeChannelBeta[];

224 extern const wchar_t kChromeChannelStable[];	226 extern const wchar_t kChromeChannelStable[];

225	227

226 extern const size_t kMaxAppModelIdLength;	228 extern const size_t kMaxAppModelIdLength;

227	229

228 } // namespace installer	230 } // namespace installer

229	231

230 #endif // CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_	232 #endif // CHROME_INSTALLER_UTIL_UTIL_CONSTANTS_H_

OLD	NEW