chrome/installer/util/util_constants.cc - Issue 10912096: C++ reability review for gab.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/util/util_constants.cc

Issue 10912096: C++ reability review for gab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/installer/setup/setup_util.cc ('K') | « chrome/installer/util/util_constants.h ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 //Pickup file for readability review.

	6

5 #include "chrome/installer/util/util_constants.h"	7 #include "chrome/installer/util/util_constants.h"

6	8

7 namespace installer {	9 namespace installer {

8	10

9 namespace switches {	11 namespace switches {

10	12

11 // Whether to set Chrome to launch at computer startup.	13 // Whether to set Chrome to launch at computer startup.

12 const char kAutoLaunchChrome[] = "auto-launch-chrome";	14 const char kAutoLaunchChrome[] = "auto-launch-chrome";

13	15

14 // Install Chrome.	16 // Install Chrome.

(...skipping 206 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
221 // Chrome channel display names.	223 // Chrome channel display names.

222 const wchar_t kChromeChannelUnknown[] = L"unknown";	224 const wchar_t kChromeChannelUnknown[] = L"unknown";

223 const wchar_t kChromeChannelCanary[] = L"canary";	225 const wchar_t kChromeChannelCanary[] = L"canary";

224 const wchar_t kChromeChannelDev[] = L"dev";	226 const wchar_t kChromeChannelDev[] = L"dev";

225 const wchar_t kChromeChannelBeta[] = L"beta";	227 const wchar_t kChromeChannelBeta[] = L"beta";

226 const wchar_t kChromeChannelStable[] = L"";	228 const wchar_t kChromeChannelStable[] = L"";

227	229

228 const size_t kMaxAppModelIdLength = 64U;	230 const size_t kMaxAppModelIdLength = 64U;

229	231

230 } // namespace installer	232 } // namespace installer

OLD	NEW