chrome/installer/setup/setup_util.h - Issue 10912096: C++ reability review for gab.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/setup/setup_util.h

Issue 10912096: C++ reability review for gab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // This file declares util functions for setup project.	5 // This file declares util functions for setup project.

6	6

	7 //Pickup file for readability review.

	8

7 #ifndef CHROME_INSTALLER_SETUP_SETUP_UTIL_H_	9 #ifndef CHROME_INSTALLER_SETUP_SETUP_UTIL_H_

8 #define CHROME_INSTALLER_SETUP_SETUP_UTIL_H_	10 #define CHROME_INSTALLER_SETUP_SETUP_UTIL_H_

9	11

10 #include <windows.h>	12 #include <windows.h>

11	13

12 #include "base/basictypes.h"	14 #include "base/basictypes.h"

13 #include "base/file_path.h"	15 #include "base/file_path.h"

14 #include "base/string16.h"	16 #include "base/string16.h"

15 #include "base/version.h"	17 #include "base/version.h"

16 #include "base/win/scoped_handle.h"	18 #include "base/win/scoped_handle.h"

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 // The previous state of the privilege this object is responsible for. As set	75 // The previous state of the privilege this object is responsible for. As set

74 // by AdjustTokenPrivileges() upon construction.	76 // by AdjustTokenPrivileges() upon construction.

75 TOKEN_PRIVILEGES previous_privileges_;	77 TOKEN_PRIVILEGES previous_privileges_;

76	78

77 DISALLOW_IMPLICIT_CONSTRUCTORS(ScopedTokenPrivilege);	79 DISALLOW_IMPLICIT_CONSTRUCTORS(ScopedTokenPrivilege);

78 };	80 };

79	81

80 } // namespace installer	82 } // namespace installer

81	83

82 #endif // CHROME_INSTALLER_SETUP_SETUP_UTIL_H_	84 #endif // CHROME_INSTALLER_SETUP_SETUP_UTIL_H_

OLD	NEW

« chrome/installer/setup/install_worker.cc ('K') | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/setup/setup_util.cc » ('j') | chrome/installer/setup/setup_util.cc » ('J')