chrome/installer/setup/setup_main.cc - Issue 10912096: C++ reability review for gab.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/setup/setup_main.cc

Issue 10912096: C++ reability review for gab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 //Pickup file for readability review.

	6

5 #include <windows.h>	7 #include <windows.h>

6 #include <msi.h>	8 #include <msi.h>

7 #include <shellapi.h>	9 #include <shellapi.h>

8 #include <shlobj.h>	10 #include <shlobj.h>

9	11

10 #include "base/at_exit.h"	12 #include "base/at_exit.h"

11 #include "base/basictypes.h"	13 #include "base/basictypes.h"

12 #include "base/command_line.h"	14 #include "base/command_line.h"

13 #include "base/file_util.h"	15 #include "base/file_util.h"

14 #include "base/file_version_info.h"	16 #include "base/file_version_info.h"

(...skipping 1493 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1508 if (!(installer_state.is_msi() && is_uninstall))	1510 if (!(installer_state.is_msi() && is_uninstall))

1509 // Note that we allow the status installer::UNINSTALL_REQUIRES_REBOOT	1511 // Note that we allow the status installer::UNINSTALL_REQUIRES_REBOOT

1510 // to pass through, since this is only returned on uninstall which is	1512 // to pass through, since this is only returned on uninstall which is

1511 // never invoked directly by Google Update.	1513 // never invoked directly by Google Update.

1512 return_code = InstallUtil::GetInstallReturnCode(install_status);	1514 return_code = InstallUtil::GetInstallReturnCode(install_status);

1513	1515

1514 VLOG(1) << "Installation complete, returning: " << return_code;	1516 VLOG(1) << "Installation complete, returning: " << return_code;

1515	1517

1516 return return_code;	1518 return return_code;

1517 }	1519 }

OLD	NEW

« chrome/installer/setup/install_worker.cc ('K') | « chrome/installer/setup/install_worker.cc ('k') | chrome/installer/setup/setup_util.h » ('j') | chrome/installer/setup/setup_util.cc » ('J')