Switch to AVIO instead of a custom FFmpeg URLProtocol handler.

media/filters/ffmpeg_demuxer.h

Index: media/filters/ffmpeg_demuxer.h
diff --git a/media/filters/ffmpeg_demuxer.h b/media/filters/ffmpeg_demuxer.h
index 9a96a19e1bb53ee025746f2ac2c1a199f452e576..823ec93615e30e334e66208c5d47c0a5a0aea8cf 100644
--- a/media/filters/ffmpeg_demuxer.h
+++ b/media/filters/ffmpeg_demuxer.h
@@ -36,7 +36,6 @@
 #include "media/filters/ffmpeg_glue.h"
 
 // FFmpeg forward declarations.
-struct AVFormatContext;
 struct AVPacket;
 struct AVRational;
 struct AVStream;
@@ -159,7 +158,7 @@ class MEDIA_EXPORT FFmpegDemuxer : public Demuxer, public FFmpegURLProtocol {
   virtual base::TimeDelta GetStartTime() const OVERRIDE;
 
   // FFmpegURLProtocol implementation.

[Ami GONE FROM CHROMIUM, 2012/09/27 03:24:45]

What now?

[DaleCurtis, 2012/09/27 03:46:12]

Figured the rename is best done in another CL / after initial review for diff
clarity.

-  virtual size_t Read(size_t size, uint8* data) OVERRIDE;
+  virtual int Read(int size, uint8* data) OVERRIDE;
   virtual bool GetPosition(int64* position_out) OVERRIDE;
   virtual bool SetPosition(int64 position) OVERRIDE;
   virtual bool GetSize(int64* size_out) OVERRIDE;
@@ -221,9 +220,6 @@ class MEDIA_EXPORT FFmpegDemuxer : public Demuxer, public FFmpegURLProtocol {
 
   scoped_refptr<base::MessageLoopProxy> message_loop_;
 
-  // FFmpeg context handle.
-  AVFormatContext* format_context_;
-
   // |streams_| mirrors the AVStream array in |format_context_|. It contains
   // FFmpegDemuxerStreams encapsluating AVStream objects at the same index.
   //
@@ -268,6 +264,9 @@ class MEDIA_EXPORT FFmpegDemuxer : public Demuxer, public FFmpegURLProtocol {
   // stream -- at this moment we definitely know duration.
   bool duration_known_;
 
+  // Binding glue for interfacing with FFmpeg.

[scherkus (not reviewing), 2012/10/02 00:20:56]

I'd ditch the comment -- you haven't commented it in other instances and the
name is pretty self-explanatory

[DaleCurtis, 2012/10/02 01:24:23]

Done.

+  scoped_ptr<FFmpegGlue> glue_;
+
   DISALLOW_COPY_AND_ASSIGN(FFmpegDemuxer);
 };