Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: webkit/plugins/ppapi/plugin_module.h

Issue 10912060: Allow the NaCl IPC proxy to support multiple instances. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/plugin_module.h
===================================================================
--- webkit/plugins/ppapi/plugin_module.h (revision 154244)
+++ webkit/plugins/ppapi/plugin_module.h (working copy)
@@ -105,7 +105,12 @@
// ownership of the given pointer, even in the failure case.
void InitAsProxied(PluginDelegate::OutOfProcessProxy* out_of_process_proxy);
- // Initializes this module for the given NaCl proxy. This takes
+ // Creates a new module for a NaCl instance that will be using the IPC proxy.
+ // We can't use the existing module, or new instances of the plugin can't
+ // be created.
+ scoped_refptr<PluginModule> CreateModuleForNaClInstance();
+
+ // Initializes the NaCl module for the given out of process proxy. This takes
// ownership of the given pointer, even in the failure case.
void InitAsProxiedNaCl(
scoped_ptr<PluginDelegate::OutOfProcessProxy> out_of_process_proxy,
@@ -234,8 +239,6 @@
PP_Bool (*reserve_instance_id_)(PP_Module, PP_Instance);
- bool nacl_ipc_proxy_;
-
DISALLOW_COPY_AND_ASSIGN(PluginModule);
};

Powered by Google App Engine
This is Rietveld 408576698